Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sumologicexporter] Add prometheus formatter for metrics #1890

Conversation

sumo-drosiek
Copy link
Member

Description:
Add prometheus formatter for metrics.

NOTE: metricPair is a structure which will hold information about metrics attributes and metrics itself.
This structure is required to handle all information we want to export to sumologic

Link to tracking Issue: #1498

Testing:

  • Unit tests
  • Visual comparison tests with prometheus exporter

Documentation:
In-code comments

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek requested a review from a team December 22, 2020 08:52
@sumo-drosiek
Copy link
Member Author

cc: @pmalek-sumo @pmm-sumo

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #1890 (595f510) into master (fe1b43a) will increase coverage by 0.19%.
The diff coverage is 99.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1890      +/-   ##
==========================================
+ Coverage   89.90%   90.10%   +0.19%     
==========================================
  Files         380      382       +2     
  Lines       18335    18756     +421     
==========================================
+ Hits        16484    16900     +416     
- Misses       1385     1388       +3     
- Partials      466      468       +2     
Flag Coverage Δ
integration 69.82% <ø> (ø)
unit 88.84% <99.52%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/sumologicexporter/sender.go 91.45% <ø> (ø)
exporter/sumologicexporter/prometheus_formatter.go 99.20% <99.20%> (ø)
exporter/sumologicexporter/test_data.go 100.00% <100.00%> (ø)
receiver/k8sclusterreceiver/watcher.go 95.29% <0.00%> (-2.36%) ⬇️
processor/groupbytraceprocessor/event.go 95.96% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1b43a...595f510. Read the comment docs.

@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumo-prometheus-formatter branch from 322b1cf to 9acd1af Compare December 28, 2020 08:41
Dominik Rosiek added 2 commits December 28, 2020 10:07
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumo-prometheus-formatter branch from 9acd1af to 595f510 Compare December 28, 2020 09:07
@bogdandrutu bogdandrutu merged commit af6dbf9 into open-telemetry:master Jan 3, 2021
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
…rape metrics slice or resource metrics slice instead of having to return a metrics data object) (#1890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants