Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/jaegerremotesampling] remove misleading agent endpoint #18070

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .chloggen/remove_misleading_jaegerremotesampling_endpoint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix
frzifus marked this conversation as resolved.
Show resolved Hide resolved

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: extension/jaegerremotesampling

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove misleading http endpoint from jaegerremotesampling extension.

# One or more tracking issues related to the change
issues: [18058]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
3 changes: 0 additions & 3 deletions extension/jaegerremotesampling/internal/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ func NewHTTP(telemetry component.TelemetrySettings, settings confighttp.HTTPServ
}

srv.mux = http.NewServeMux()
// the legacy endpoint
srv.mux.Handle("/", http.HandlerFunc(srv.samplingStrategyHandler))

// the new endpoint -- not strictly necessary, as the previous one would match it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may want to fix the comment: "the previous one" doesn't exist anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, good catch :X

// already, but good to have it explicit here
srv.mux.Handle("/sampling", http.HandlerFunc(srv.samplingStrategyHandler))
Expand Down
4 changes: 0 additions & 4 deletions extension/jaegerremotesampling/internal/http_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ func TestEndpointsAreWired(t *testing.T) {
desc string
endpoint string
}{
{
desc: "legacy",
endpoint: "/",
},
{
desc: "new",
endpoint: "/sampling",
Expand Down