Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/azuremonitor] Fix CI #18038

Merged

Conversation

eedorenko
Copy link
Contributor

Fixes CI build
#14916 (comment)

@runforesight
Copy link

runforesight bot commented Jan 25, 2023

Foresight Summary

    
Major Impacts
Foresight hasn't detected any major impact on your workflows and tests.

View More Details

✅  check-links workflow has finished in 1 minute 34 seconds and finished at 25th Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 46 seconds (39 seconds less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 49 seconds (37 seconds less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
publish-latest -     🔗  N/A See Details
build-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

⭕  changelog workflow has finished in 3 seconds (2 minutes 1 second less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 5 seconds (41 minutes 16 seconds less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

 build-and-test workflow has finished in 5 minutes 44 seconds (46 minutes 24 seconds less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
correctness-metrics N/A  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces N/A  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) N/A  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) N/A  ✅ 1471  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) N/A  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) N/A  ✅ 1471  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) N/A  ✅ 2567  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) N/A  ✅ 2567  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) N/A  ✅ 1905  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) N/A  ✅ 2435  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) N/A  ✅ 1905  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) N/A  ✅ 4630  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) N/A  ✅ 2435  ❌ 0  ⏭ 0    🔗 See Details
integration-tests N/A  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) N/A  ✅ 4630  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 11 minutes 21 seconds (2 minutes 54 seconds less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 13 minutes 13 seconds (⚠️ 5 minutes 39 seconds more than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@eedorenko
Copy link
Contributor Author

FYI @jpkrohling

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixes the tests. Before this fix:

> make test
go: downloading code.cloudfoundry.org/clock v0.0.0-20180518195852-02e53af36e6c
if [ "" = "true" ]; then \
	go test -race -timeout 300s -parallel 4 --tags="" -v ./... 2>&1 | tee -a ./foresight-test-report.txt; \
else \
	go test -race -timeout 300s -parallel 4 --tags="" ./...; \
fi
# github.com/open-telemetry/opentelemetry-collector-contrib/exporter/azuremonitorexporter [github.com/open-telemetry/opentelemetry-collector-contrib/exporter/azuremonitorexporter.test]
./metricexporter.go:44:22: cannot use exporter.config.InstrumentationKey (variable of type configopaque.String) as type string in assignment
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/azuremonitorexporter [build failed]
FAIL
make: *** [../../Makefile.Common:97: test] Error 2

After:

> make test
if [ "" = "true" ]; then \
	go test -race -timeout 300s -parallel 4 --tags="" -v ./... 2>&1 | tee -a ./foresight-test-report.txt; \
else \
	go test -race -timeout 300s -parallel 4 --tags="" ./...; \
fi
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/azuremonitorexporter	0.044s

@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 25, 2023
@jpkrohling jpkrohling assigned eedorenko and unassigned dashpole Jan 25, 2023
@codeboten codeboten merged commit e77c342 into open-telemetry:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/azuremonitor Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants