[sumologicexporter] Add extrapolation of source headers #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1756 +/- ##
==========================================
- Coverage 89.51% 89.51% -0.01%
==========================================
Files 376 378 +2
Lines 18318 18342 +24
==========================================
+ Hits 16398 16418 +20
- Misses 1422 1424 +2
- Partials 498 500 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@sumo-drosiek anyone from your company can pre-review and approve this? |
|
@bogdandrutu |
|
@sumo-drosiek ok, but would be good if they approve PRs here as well so I can have a confirmation that I am not merging un-reviewed things. |
bogdandrutu
approved these changes
Dec 7, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
To help reviewers and authors remember to make progress on PR this action will mark PRs as stale after inactivity of 7 days and will close the PR after 7 more days of inactivity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add extrapolation of source headers. For
sourceName,sourceHostandsourceCategoryheaders, the%{attribute_name}will be replaced withattribute_value, so one can inject eg.clusterornamespacename into mentioned headers.Example:
For
cluster=kubernetesandnamespace=sumologic,%{cluster}/%{namespace}becomeskubernetes/sumologicLink to tracking Issue:
#1498
Testing:
Unit tests
Documentation:
comments