Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza/adapter] Deprecate Convert helper #17450

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jan 9, 2023

Convert helper was introduced in #3125, but was never used.

Now we have pkg/stanza/adapter exposed as a public API, it's important to limit its scope.

@dmitryax dmitryax requested a review from a team January 9, 2023 17:23
@dmitryax dmitryax requested a review from djaglowski as a code owner January 9, 2023 17:23
@runforesight
Copy link

runforesight bot commented Jan 9, 2023

Foresight Summary

    
Major Impacts

TestAerospikeIntegration ❌ failed 1 times in 2 runs (50% fail rate).
build-and-test-windows duration(58 seconds) has decreased 43 minutes 35 seconds compared to main branch avg(44 minutes 33 seconds).
View More Details

✅  check-links workflow has finished in 13 minutes 21 seconds (⚠️ 10 minutes 39 seconds more than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  tracegen workflow has finished in 14 minutes 13 seconds (⚠️ 11 minutes 7 seconds more than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 17 minutes 32 seconds (⚠️ 8 minutes 48 seconds more than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 42 minutes 23 seconds (⚠️ 26 minutes 28 seconds more than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

⭕  changelog workflow has finished in 58 seconds (8 minutes 30 seconds less than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 58 seconds (43 minutes 35 seconds less than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

 build-and-test workflow has finished in 2 minutes 43 seconds (44 minutes 36 seconds less than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
integration-tests N/A  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@dmitryax
Copy link
Member Author

dmitryax commented Jan 9, 2023

@djaglowski It'd be nice if we can merge it before releasing 0.68.0. Test coverage for this function has a bunch of Map.Sort which I would like to remove instead of reworking

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 9, 2023
@djaglowski djaglowski merged commit 44f0923 into open-telemetry:main Jan 9, 2023
@dmitryax dmitryax deleted the deprecate-adapter-convert branch January 10, 2023 13:05
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/stanza Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants