Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] Mark unrecoverable errors as permanent #17386

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Jan 4, 2023

Description:

Add a helper function that wraps unrecoverable errors with consumererror.Permanent so that they are not retried.

Right now the Datadog metrics exporter retries on all errors, but there are certain response status code that indicates the error is unrecoverable and thus shouldn't be retried: https://github.com/DataDog/datadog-agent/blob/89b27708ab6872a0208fae3b98ccf70a8bac6b79/pkg/forwarder/transaction/transaction.go#L337-L354.

Link to tracking Issue:

Testing:

Documentation:

@songy23 songy23 requested a review from a team January 4, 2023 22:07
@songy23 songy23 requested a review from mx-psi as a code owner January 4, 2023 22:07
@github-actions github-actions bot added the exporter/datadog Datadog components label Jan 4, 2023
@songy23
Copy link
Member Author

songy23 commented Jan 4, 2023

Please add Skip Changelog since this PR is not directly visible to users.

@runforesight
Copy link

runforesight bot commented Jan 4, 2023

Foresight Summary

    
Major Impacts
Foresight hasn't detected any major impact on your workflows and tests.

View More Details

 build-and-test workflow has finished in 20 minutes 31 seconds (26 minutes 31 seconds less than main branch avg.) and finished at 10th Jan, 2023.


Job Failed Steps Tests
integration-tests N/A  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@songy23 songy23 force-pushed the ddog-api-validation branch 2 times, most recently from 7db40a2 to c5702e7 Compare January 6, 2023 14:53
@songy23 songy23 force-pushed the ddog-api-validation branch from c5702e7 to 6f05620 Compare January 9, 2023 17:48
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 10, 2023
@mx-psi mx-psi merged commit c3bd1e6 into open-telemetry:main Jan 11, 2023
@songy23 songy23 deleted the ddog-api-validation branch January 11, 2023 14:02
@mx-psi mx-psi mentioned this pull request Jan 30, 2023
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/datadog Datadog components Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants