[exporter/datadog] Mark unrecoverable errors as permanent #17386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a helper function that wraps unrecoverable errors with consumererror.Permanent so that they are not retried.
Right now the Datadog metrics exporter retries on all errors, but there are certain response status code that indicates the error is unrecoverable and thus shouldn't be retried: https://github.com/DataDog/datadog-agent/blob/89b27708ab6872a0208fae3b98ccf70a8bac6b79/pkg/forwarder/transaction/transaction.go#L337-L354.
Link to tracking Issue:
Testing:
Documentation: