Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlibabaCloud LogService Exporter - support new trace interface #1713

Merged
merged 3 commits into from
Dec 1, 2020

Conversation

shabicheng
Copy link
Contributor

Description:

  • change trace type from opencensus to opentelemetry

Link to tracking Issue:

Testing:

  • unit test has passed with coverage 100%.
  • Manually tested, sending to a LogService's instance.

Documentation:
No need to update readme.

@shabicheng shabicheng requested a review from a team November 30, 2020 04:31
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #1713 (6e77291) into master (0705ace) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
- Coverage   89.54%   89.48%   -0.06%     
==========================================
  Files         373      373              
  Lines       18233    18143      -90     
==========================================
- Hits        16326    16235      -91     
- Misses       1417     1419       +2     
+ Partials      490      489       -1     
Flag Coverage Δ
integration 70.97% <ø> (ø)
unit 88.17% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/alibabacloudlogserviceexporter/trace_exporter.go 100.00% <100.00%> (ø)
...cloudlogserviceexporter/tracedata_to_logservice.go 100.00% <100.00%> (ø)
receiver/prometheusexecreceiver/receiver.go 85.83% <0.00%> (-2.50%) ⬇️
receiver/k8sclusterreceiver/watcher.go 97.64% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0705ace...6e77291. Read the comment docs.

@shabicheng
Copy link
Contributor Author

@bogdandrutu @tigrannajaryan Hi, could you please add my partner @kongluoxing as one of this exporter's codeowners, we will do the reviews directly in this repository.

@bogdandrutu
Copy link
Member

@shabicheng please create a PR to add them to the codeowners file

@bogdandrutu
Copy link
Member

@shabicheng I will expect the other owner to approve the PR at one point :)

Copy link

@kongluoxing kongluoxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu merged commit cf55673 into open-telemetry:master Dec 1, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
* Add metric correctness support to testbed

* Rebase, use new metric types
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
Migrate to using go.opentelemetry.io/proto/otlp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants