-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlibabaCloud LogService Exporter - support new trace interface #1713
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1713 +/- ##
==========================================
- Coverage 89.54% 89.48% -0.06%
==========================================
Files 373 373
Lines 18233 18143 -90
==========================================
- Hits 16326 16235 -91
- Misses 1417 1419 +2
+ Partials 490 489 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@bogdandrutu @tigrannajaryan Hi, could you please add my partner @kongluoxing as one of this exporter's codeowners, we will do the reviews directly in this repository. |
@shabicheng please create a PR to add them to the codeowners file |
@shabicheng I will expect the other owner to approve the PR at one point :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add metric correctness support to testbed * Rebase, use new metric types
Migrate to using go.opentelemetry.io/proto/otlp
Description:
Link to tracking Issue:
Testing:
Documentation:
No need to update readme.