Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/purefa] Adds a new scrapper type directories #16590

Conversation

dgoscn
Copy link
Contributor

@dgoscn dgoscn commented Dec 2, 2022

Description:
Adds the directories scraper and the new scraperType for the core code, being more flexibe via const variables.

Link to tracking Issue:
#14886

Testing:
Only tests from the respective golang files

Documentation:
Still in progress

@dgoscn dgoscn requested a review from a team December 2, 2022 17:55
@runforesight
Copy link

runforesight bot commented Dec 2, 2022

Foresight Summary

    
Major Impacts

TestIntegrationSingleNode ❌ failed 1 times in 1 runs (100% fail rate).
build-and-test-windows duration(3 seconds) has decreased 32 minutes 55 seconds compared to main branch avg(32 minutes 58 seconds).
View More Details

✅  check-links workflow has finished in 40 seconds (1 minute 23 seconds less than main branch avg.) and finished at 2nd Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute (1 minute 17 seconds less than main branch avg.) and finished at 2nd Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 3 seconds (32 minutes 53 seconds less than main branch avg.) and finished at 2nd Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

⭕  changelog workflow has finished in 3 seconds (4 minutes 59 seconds less than main branch avg.) and finished at 2nd Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 26 seconds (4 minutes 40 seconds less than main branch avg.) and finished at 2nd Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 9 minutes 58 seconds (4 minutes 7 seconds less than main branch avg.) and finished at 2nd Dec, 2022.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  build-and-test workflow has finished in 38 minutes 24 seconds (15 minutes 19 seconds less than main branch avg.) and finished at 4th Dec, 2022.


Job Failed Steps Tests
integration-tests -     🔗  ✅ 59  ❌ 0  ⏭ 0    🔗 See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@dgoscn dgoscn marked this pull request as draft December 2, 2022 18:05
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling force-pushed the purestorage_flasharray_newscraper_directories branch from 3fc2ec1 to dd3bd71 Compare December 2, 2022 21:12
@jpkrohling jpkrohling marked this pull request as ready for review December 2, 2022 21:12
@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 2, 2022
@jpkrohling jpkrohling merged commit b0de453 into open-telemetry:main Dec 5, 2022
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants