Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Foresight Github actions to collect detailed workflow metrics and test results #16427

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Add Foresight Github actions to collect detailed workflow metrics and test results #16427

merged 1 commit into from
Nov 28, 2022

Conversation

serkan-ozal
Copy link

Hi Otel community,

Thanks for using Foresight to monitor your Github actions.

Currently OTEL Foresight public view is open to everyone here: otel.app.runforesight.com

Description:
This PR adds Foresight workflow-kit and test-kit Github actions into workflows to collect detailed workflow metrics (process traces, CPU/Memory/IO metrics) and test results.

@serkan-ozal serkan-ozal requested review from a team and mx-psi November 22, 2022 11:17
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 22, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: serkan-ozal / name: Serkan ÖZAL (6eb200617bd61b297753cb805175fd9bcb275414)

@serkan-ozal serkan-ozal mentioned this pull request Nov 22, 2022
Closed
jpkrohling
jpkrohling reviewed Nov 23, 2022
View reviewed changes
.github/workflows/build-and-test.yml Show resolved Hide resolved
Makefile.Common Outdated Show resolved Hide resolved
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 24, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: serkan-ozal / name: Serkan ÖZAL (ce31e9b)

jpkrohling
jpkrohling requested changes Nov 24, 2022
View reviewed changes
Makefile.Common Show resolved Hide resolved
@serkan-ozal serkan-ozal requested review from jpkrohling and removed request for mx-psi November 27, 2022 17:05
@serkan-ozal
Copy link
Author

Hi @jpkrohling, @mx-psi,

Do you know why changelog check result fails? https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3541687191/jobs/5946469286
What should we do to get it passed?

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 28, 2022
jpkrohling
jpkrohling approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test the make test output this time again but verified it earlier. I assume this hasn't changed since I last checked. Therefore, LGTM.

@jpkrohling jpkrohling merged commit 5dc292d into open-telemetry:main Nov 28, 2022
@mx-psi mx-psi mentioned this pull request Dec 2, 2022
Closed
@serkan-ozal serkan-ozal mentioned this pull request Dec 6, 2022
Merged
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@shalper2
Add Foresight Github actions to collect detailed workflow metrics and…
b743b1a 
… test results (open-telemetry#16427)
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi left review comments

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serkan-ozal @jpkrohling @mx-psi @bogdandrutu