Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS for core components #15376

Merged
merged 4 commits into from
Oct 24, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 21, 2022

Description:

Add CODEOWNERs for several shared components. For most of them I added core approvers, some are only contrib.

Link to tracking Issue: Updates #3870

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 21, 2022
@mx-psi mx-psi requested review from a team and dashpole October 21, 2022 10:37
@mx-psi
Copy link
Member Author

mx-psi commented Oct 21, 2022

cc @open-telemetry/collector-contrib-approvers

@bogdandrutu
Copy link
Member

Please fix the conflicts

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

.github/CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
@mx-psi mx-psi requested a review from dmitryax October 24, 2022 11:15
@codeboten codeboten merged commit bfa5eb1 into open-telemetry:main Oct 24, 2022
@mx-psi mx-psi deleted the mx-psi/common-components branch October 24, 2022 15:33
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
Add CODEOWNERs for several shared components. For most of them I added core approvers, some are only contrib.

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants