Initialise Sumo Logic exporter #1499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
force-pushed
the
drosiek-sumologic-output-init
branch
from
1d9edbb to
811200b
Compare
sumo-drosiek
force-pushed
the
drosiek-sumologic-output-init
branch
from
811200b to
92f1366
Compare
sumo-drosiek
force-pushed
the
drosiek-sumologic-output-init
branch
from
6afbfae to
028acd2
Compare
sumo-drosiek
force-pushed
the
drosiek-sumologic-output-init
branch
from
fc112a9 to
005f979
Compare
bogdandrutu
reviewed
Nov 9, 2020
bogdandrutu
approved these changes
Nov 10, 2020
exporter/sumologicexporter/config.go
Outdated
Comment on lines
32
to
35
| // Option to enable compression (default true) | ||
| Compress bool `mapstructure:"compress"` | ||
| // Compression encoding format, either gzip or deflate (default gzip) | ||
| CompressEncoding CompressEncodingType `mapstructure:"compress_encoding"` |
There was a problem hiding this comment.
I think you don't need both these options. You can have only CompressEncoding and:
- "" - disabled
- "gzip" - gzip
- "deflate" - deflate
There was a problem hiding this comment.
Thats reasonable. It will simplify the further PR too, so I changed it.
|
@sumo-drosiek ping |
To disable compression empty string ("") should be used
|
@sumo-drosiek I think there is a problem with circle CI and this PR. Can you open a new Pr with the same changes? |
|
@bogdandrutu Sure, it can be due to using circle CI on our fork. I created PR from my personal account. It should works fine now. Here is the PR #1565 |
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Initialise Sumo Logic exporter
Link to tracking Issue: #1498
Testing:
Unit tests
Documentation:
Readme