Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/hostmetrics] remove direction feature gate #14959

Merged
merged 3 commits into from
Oct 14, 2022
Merged

[receiver/hostmetrics] remove direction feature gate #14959

merged 3 commits into from
Oct 14, 2022

Conversation

codeboten
Copy link
Contributor

The following feature gates have been removed after being deprecated for a few versions:

  • receiver.hostmetricsreceiver.emitMetricsWithoutDirectionAttribute
  • receiver.hostmetricsreceiver.emitMetricsWithDirectionAttribute

[receiver/hostmetrics] remove direction feature gate
42bc7a8 
The following feature gates have been removed after being deprecated for a few versions:

- `receiver.hostmetricsreceiver.emitMetricsWithoutDirectionAttribute`
- `receiver.hostmetricsreceiver.emitMetricsWithDirectionAttribute`
@codeboten codeboten requested a review from a team October 14, 2022 16:29
@dmitryax
Copy link
Member

PTAL at the failing tests

@codeboten codeboten merged commit b846f2d into open-telemetry:main Oct 14, 2022
@codeboten codeboten deleted the codeboten/rm-direction-changes-hostmetrics branch October 14, 2022 18:10
@rubenruizdegauna
Copy link
Contributor

In this issue, #11820 direction was removed from attributes in favor of metric name (using a feature gate).

In this PR the feature gate has been removed but the direction continues to be an attribute instead of being in the metric name. I was expecting to see the code under emitMetricsWithoutDirectionAttribute as the final version and not having direction as an attribute but I might be missing something.

Has the decision been changed?

shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@shalper2
[receiver/hostmetrics] remove direction feature gate (open-telemetry#…
e99d953 
…14959)

The following feature gates have been removed after being deprecated for a few versions:

- `receiver.hostmetricsreceiver.emitMetricsWithoutDirectionAttribute`
- `receiver.hostmetricsreceiver.emitMetricsWithDirectionAttribute`
@rubenruizdegauna
Copy link
Contributor

In this issue, #11820 direction was removed from attributes in favor of metric name (using a feature gate).

In this PR the feature gate has been removed but the direction continues to be an attribute instead of being in the metric name. I was expecting to see the code under emitMetricsWithoutDirectionAttribute as the final version and not having direction as an attribute but I might be missing something.

Has the decision been changed?

Answering myself, I just saw that it was reverted for some metrics open-telemetry/opentelemetry-specification#2726 👍

@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

Assignees

@mx-psi mx-psi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codeboten @dmitryax @rubenruizdegauna @mx-psi