[receiver/snowflakereceiver] New Snowflake receiver #14778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
requested review from
dmitryax
and removed request for
bogdandrutu
dmitryax
reviewed
Oct 10, 2022
dmitryax
approved these changes
Oct 17, 2022
|
Since this PR is pretty empty. I can merge it without a changelog entry. But please add a "new component" changelog entry in one of the next PRs https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/.chloggen |
|
@shalper2 looks like Makefile is missed |
|
The makefile shouldn't be empty. PTAL at other components |
|
Another failing check. the component must be listed in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/CODEOWNERS . Please mention your and my github handles there |
|
linter is failing due to missing |
|
@shalper2 couple other checks are still failing, PTAL |
dmitryax
reviewed
Oct 18, 2022
dmitryax
reviewed
Oct 18, 2022
|
@shalper2 there is one last failing check , PTAL |
kovrus
added a commit
to kovrus/opentelemetry-collector-contrib
that referenced
this pull request
Oct 19, 2022
The collector build is broken by open-telemetry#14778
shalper2
added a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…lemetry#14778) Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
New Snowflake receiver component
Link to tracking Issue:
Closes #14754
Testing:
Simple functional testing as with other components
Documentation:
Metrics to be generated with mdatagen and metadata.yaml.