new receiver prometheusremotewritereceiver
#14752
Conversation
| @@ -178,6 +178,7 @@ receiver/otlpjsonfilereceiver/ @open-telemetry/collector-c | |||
| receiver/postgresqlreceiver/ @open-telemetry/collector-contrib-approvers @djaglowski | |||
| receiver/prometheusexecreceiver/ @open-telemetry/collector-contrib-approvers @dmitryax | |||
| receiver/prometheusreceiver/ @open-telemetry/collector-contrib-approvers @Aneurysm9 @dashpole | |||
| receiver/prometheusremotewritereceiver/ @open-telemetry/collector-contrib-approvers @Norbertwnuk @adamkubon | |||
There was a problem hiding this comment.
Hi @norbertwnuk 👋🏽, nice to see you here!
adamkubon
force-pushed
the
feature/prometheusremotewritereceiver
branch
from
a688e2d to
6a9ddec
Compare
adamkubon
force-pushed
the
feature/prometheusremotewritereceiver
branch
from
6a9ddec to
1b25f8e
Compare
|
@norbertwnuk, could you also please review this one? This cannot be merged until we have at least one sponsor for this component. Besides that, I would like to ask what would be your availability in the future to maintain this component. |
adamkubon
force-pushed
the
feature/prometheusremotewritereceiver
branch
from
1b25f8e to
8cfc830
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
adamkubon
force-pushed
the
feature/prometheusremotewritereceiver
branch
4 times, most recently
from
d33b9dd to
5e4ba23
Compare
|
@adamkubon, @norbertwnuk, are you still interested in this one? |
|
Yes definitely We are, sorry for late response due to PTO |
adamkubon
force-pushed
the
feature/prometheusremotewritereceiver
branch
from
5e4ba23 to
c5e0027
Compare
|
Hi @adamkubon @norbertwnuk, I would like to join you with the work on the remote-write receiver since I have some time allocated for this work and further share the code ownership for this component. I am also fine with taking it over if you do not have enough resources. I have no comments regarding the component itself, but we would have to develop some strategy for Prometheus -> OTLP metrics mapping. We might probably have to think about using metadata that is pushed via rw or maybe querying Prometheus API for metadata to correctly determine metrics types since it is not always possible to infer it from the metric name? |
|
Hi, what is involved in becoming a sponsor? We at MYOB use remotewrite -> OTLP heavily with our own custom receiver (amongst several others) and may consider sponsorship. |
Sponsorship is about finding a maintainer or approver who will act as official reviewer and one of code owners for this component, see https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components |
|
@kovrus any luck with finding a sponsor so far? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Is there any update of this PR? We need this feature. +1 And seems it's lots of changes in main, and this PR cannot run with the latest main branch, can you update to latest version so we can build a custom binary? |
I think that @atoulme mentioned that there was someone who wanted to contribute probably something close to the "best effort" implementation from this design doc. |
|
I have a branch on my end I'm testing which will impl it via best effort. Sorry I should have started from this PR but I more or less wrote an independent one with an aim of replacing some functionality on our end. I was going to merge it into our "splunk" distribution of the collector to vet it before merging upstream, but if you think it worthy I could try to directly target -contrib |
|
.... Looking over your code vs mine, I think we'll (my team) put it in our (splunk's) distro and be guinnea pigs for testing the conversion, and then take only the translation+cache stuff from mine and either have you or I migrate it + include it in this PR. Feel free to ping me on the otel slack if you want to followup |
|
Oh also, I'm putting this on the prometheus working group agenda for April 26th @ 8AM PDT Anyone interested in this PR is free to join. Sorry I'll be deploying it in our distro first, but PRW like functionality is in the critical path for us to sunset our pre-otel client and thus needed to be expedited. |
|
Hey, brought this up in today's prometheus working group, more updates to follow |
|
Hi all! Was wondering if there are any updates on this? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
We need it, please don't close it. Is there any update? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Is anyone interested in picking up this one? I'm closing for now, but if you want to continue working on this, I'll reopen it. |
|
Hey @jpkrohling, what is the process and requirements for becoming a sponsor? |
|
Approvers and maintainers are sponsors on this repository: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components |
Description: New prometheusremotewrite receiver.
Link to tracking Issue: #10358
Testing: New receiver can consume the prometheus remote write protocol
Documentation: Markdown README with config description added