[processor/resourcedetection] save "name" from Azure metadata in azure.vm.name attr #12914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…azure.vm.name attribute
mx-psi
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
LGTM, As I mentioned over at #12779 (comment) I think it would be great to have this as a semantic convention
rmfitzpatrick
approved these changes
Aug 3, 2022
dloucasfx
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Save the "name" value from the Azure metadata API in resource attribute
azure.vm.name. This value was already being saved in thehost.nameattribute, but that attribute is also used by the system detector.Link to tracking Issue: #12779
Testing: Unit tests updated. Manual testing performed on Azure.
Documentation: Field name and explanation added to readme