Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use azure.vm.name attribute in both Azure detector and SFx hostid logic #12908

Closed
wants to merge 1 commit into from
Closed

Conversation

pmcollins
Copy link
Member

Description: The Azure resource detector writes the "name" value from the Azure metadata API to the host.name attribute of the current resource. The problem with this is that the the host.name attribute is also written to by the system detector, and the Azure detector may not have precedence, in which case the Azure metadata name value won't be available downstream. The signalfx exporter requires the name from the Azure metadata API to operate (and other components may as require it as well at some point) so this change both saves this value to a new resource attribute key, azure.vm.name, (in addition to continuing to write it to the host.name attribute) and reads from this new attribute in the signalfx exporter.

Link to tracking Issue: #12779

Testing: Unit tests added. Manual testing was performed on Azure.

Documentation: Field added to readme

@dmitryax
Copy link
Member

dmitryax commented Aug 2, 2022

@pmcollins Can you please submit addition of azure.vm.name as a separate PR?

@pmcollins pmcollins closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants