clickhouseexporter: update table schema #12664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanjm
force-pushed
the
feature/exporter/clickhouse/jimmiehan-update-log
branch
2 times, most recently
from
994c60a
to
91340ee
Compare
|
hi @dmitryax , Could you help review, Thank you. |
|
Hey @hanjm can you please break down the PR into several PR per each self contained change? |
hanjm
force-pushed
the
feature/exporter/clickhouse/jimmiehan-update-log
branch
2 times, most recently
from
3dc2859
to
4589212
Compare
hanjm
changed the title
|
@dmitryax I want to split it into two PR, one for update table schema, one for update document, here is the first one, is it OK? |
|
@hanjm sounds good, thanks. Please rebase and resolve conflicts |
hanjm
force-pushed
the
feature/exporter/clickhouse/jimmiehan-update-log
branch
from
4589212
to
02f381f
Compare
|
@dmitryax rebase done, but ci breaks by other components test. |
|
@hanjm it doesn't look like it's rebased to the latest main. There are still conflicts |
hanjm
force-pushed
the
feature/exporter/clickhouse/jimmiehan-update-log
branch
from
02f381f
to
87e62dd
Compare
|
@dmitryax oh, the go.mod file is changed so frequently, I have rebase agagin, thanks. |
hanjm
force-pushed
the
feature/exporter/clickhouse/jimmiehan-update-log
branch
from
87e62dd
to
25d2297
Compare
|
@hanjm please fix a failing check |
hanjm
force-pushed
the
feature/exporter/clickhouse/jimmiehan-update-log
branch
from
3c87486
to
d0f7b75
Compare
hanjm
force-pushed
the
feature/exporter/clickhouse/jimmiehan-update-log
branch
from
d0f7b75
to
29995ec
Compare
|
@dmitryax fixed, thanks. |
dmitryax
reviewed
Aug 5, 2022
dmitryax
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
update table schema
Link to tracking Issue:
#8028
Testing:
Documentation: