-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clickhouseexporter: update table schema #12664
clickhouseexporter: update table schema #12664
Conversation
994c60a
to
91340ee
Compare
hi @dmitryax , Could you help review, Thank you. |
Hey @hanjm can you please break down the PR into several PR per each self contained change? |
3dc2859
to
4589212
Compare
@dmitryax I want to split it into two PR, one for update table schema, one for update document, here is the first one, is it OK? |
@hanjm sounds good, thanks. Please rebase and resolve conflicts |
4589212
to
02f381f
Compare
@dmitryax rebase done, but ci breaks by other components test. |
@hanjm it doesn't look like it's rebased to the latest main. There are still conflicts |
02f381f
to
87e62dd
Compare
@dmitryax oh, the go.mod file is changed so frequently, I have rebase agagin, thanks. |
87e62dd
to
25d2297
Compare
@hanjm please fix a failing check |
3c87486
to
d0f7b75
Compare
d0f7b75
to
29995ec
Compare
@dmitryax fixed, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just couple nits. Otherwise LGTM
Description:
update table schema
Link to tracking Issue:
#8028
Testing:
Documentation: