Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODEOWNERS for pkg/winperfcounters #12624

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Add CODEOWNERS for pkg/winperfcounters #12624

merged 1 commit into from
Jul 21, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jul 21, 2022

Description:

Add CODEOWNERS for pkg/winperfcounters from the CODEOWNERS of the receivers that use this:

  • activedirectorydsreceiver
  • iisreceiver
  • windowsperfcountersreceiver

Link to tracking Issue: Updates #3870

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 21, 2022
@mx-psi
Copy link
Member Author

mx-psi commented Jul 21, 2022

cc @dashpole @Mrod1598 @BinaryFissionGames would you be okay with owning this?

@mx-psi mx-psi marked this pull request as ready for review July 21, 2022 11:40
@mx-psi mx-psi requested review from a team and codeboten July 21, 2022 11:40
BinaryFissionGames
BinaryFissionGames approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with being a codeowner on this

@codeboten codeboten merged commit 5e945c3 into open-telemetry:main Jul 21, 2022
@mx-psi mx-psi deleted the mx-psi/update-codeowners-shared branch July 22, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dashpole dashpole dashpole approved these changes

@BinaryFissionGames BinaryFissionGames BinaryFissionGames approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@Mrod1598 Mrod1598 Mrod1598 approved these changes

Assignees

@TylerHelmuth TylerHelmuth

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mx-psi @codeboten @dashpole @BinaryFissionGames @TylerHelmuth @Mrod1598