Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]Add status header for receiver/signalfxreceiver #11136

Closed
wants to merge 1 commit into from
Closed

[docs]Add status header for receiver/signalfxreceiver #11136

wants to merge 1 commit into from

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Jun 18, 2022

fix part of:#10116

@my-git9
[docs]Add status header for asapauth
61f9dcf 
Signed-off-by: xin.li <xin.li@daocloud.io>
@my-git9 my-git9 requested a review from a team June 18, 2022 04:35
@my-git9 my-git9 requested a review from dmitryax as a code owner June 18, 2022 04:35
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 18, 2022
@my-git9
Copy link
Member Author

my-git9 commented Jun 21, 2022

/cc @codeboten @dmitryax

codeboten
codeboten reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title says its for asapauth but the change is in the signalfx receiver.

@dmitryax
Copy link
Member

I believe signalfx receiver already has the header

@my-git9 my-git9 changed the title [docs]Add status header for asapauth [docs]Add status header for receiver/signalfxreceiver Jun 23, 2022
@my-git9 my-git9 closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@dmitryax dmitryax

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@my-git9 @dmitryax @codeboten