Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add status header for k8sevents receiver #10464

Merged

Conversation

Frapschen
Copy link
Contributor

Description:
Add status header for k8sevents receiver

@Frapschen Frapschen requested a review from a team May 31, 2022 07:33
@Frapschen Frapschen requested a review from dmitryax as a code owner May 31, 2022 07:33
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 31, 2022
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dmitryax can the existing warning be removed or do you want to keep it?

@dmitryax
Copy link
Member

dmitryax commented Jun 9, 2022

LGTM. @dmitryax can the existing warning be removed or do you want to keep it?

I'm ok with removing it. What are we doing with other components? Do we remove that warning?

@TylerHelmuth
Copy link
Member

LGTM. @dmitryax can the existing warning be removed or do you want to keep it?

I'm ok with removing it. What are we doing with other components? Do we remove that warning?

Ya other components have been removing it.

@Frapschen Frapschen requested a review from dmitryax June 10, 2022 07:34
@codeboten codeboten merged commit 02827be into open-telemetry:main Jun 10, 2022
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
* Add status header for k8sevents receiver

* apply reviewer's suggestion

* Update README.md
@Frapschen Frapschen deleted the Add_status_header_for_k8sevents_rc branch July 7, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants