Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/cumulativetodelta] Update stability level to beta #10004

Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
The cumulativetodelta processor's config was previously updated to a stable state. I'd like to bring this component's stability level in line with that change. I know this processor is also getting production exposure, and I'd like to consider it "Stable" soon, but I don't want to jump from "In Developement" to "Stable".

This processor will likely be replaced by the transform processor, but that is a long way off. In the meantime, I'd like customers to feel better about using this processor.

@TylerHelmuth TylerHelmuth requested review from a team and mx-psi May 13, 2022 15:02
@djaglowski
Copy link
Member

#10005 should resolve the CI failures

@bogdandrutu
Copy link
Member

I would not put "stable" if we know we want to replace.

@TylerHelmuth
Copy link
Member Author

I would not put "stable" if we know we want to replace.

Thats fair, but I think Beta is still appropriate at this time.

@djaglowski
Copy link
Member

#10005 is merged. Please rebase

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 13, 2022
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, as suggested in #10006

| ------------------------ | --------- |
| Stability | [beta] |
| Supported pipeline types | metrics |
| Distribution | [contrib] |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Distribution | [contrib] |
| Distributions | [contrib] |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@codeboten codeboten merged commit 2bea866 into open-telemetry:main May 17, 2022
@TylerHelmuth TylerHelmuth deleted the cumulativetodelta-stability branch May 17, 2022 17:56
@@ -72,3 +74,6 @@ processors:
# If include/exclude are not specified
# convert all cumulative sum metrics to delta
```

[beta]: https://github.com/open-telemetry/opentelemetry-collector-contrib#beta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link was wrong @TylerHelmuth, I think it should have been:

https://github.com/open-telemetry/opentelemetry-collector#beta

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmm-sumo the stability documentation was moved after this PR had already been merged: #10120

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that. I guess we could use of link validation checker, WDYT? I can open an issue and look for something

Copy link
Contributor

@codeboten codeboten May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing! Opened an issue #10162

@pmm-sumo pmm-sumo mentioned this pull request May 19, 2022
jamesmoessis pushed a commit to jamesmoessis/opentelemetry-collector-contrib that referenced this pull request May 20, 2022
…lemetry#10004)

* Update stability level

* Updated format

* Updated distribution to distributions
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
…lemetry#10004)

* Update stability level

* Updated format

* Updated distribution to distributions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants