Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azuremonitorexporter: remove usage of LogRecord.Name field #9258

Closed
tigrannajaryan opened this issue Apr 13, 2022 · 8 comments
Closed

azuremonitorexporter: remove usage of LogRecord.Name field #9258

tigrannajaryan opened this issue Apr 13, 2022 · 8 comments
Assignees
@pcwiese
Labels
bug Something isn't working

Comments

@tigrannajaryan
Copy link
Member

LogRecord.Name field is obsolete in this repo and will be deleted soon (already deleted from OTLP).

The field is currently used by azuremonitorexporter.

Please eliminate all references to LogRecord Name()/SetName() in azuremonitorexporter. The field is obsolete and there is no replacement for it.
@tigrannajaryan tigrannajaryan added the bug Something isn't working label Apr 13, 2022
@tigrannajaryan
Copy link
Member Author

@pcwiese as a codeowner of azuremonitorexporter can you help with this?

@tigrannajaryan tigrannajaryan mentioned this issue Apr 13, 2022
Merged
@bogdandrutu
Copy link
Member

@reyang can you find an owner for the azuremonitorexporter?

@pcwiese
Copy link
Contributor

pcwiese commented Apr 19, 2022

I can take it, been busy with other stuff. This exporter isn't directly supported by MSFT

@tigrannajaryan
Copy link
Member Author

Thanks @pcwiese, please do. I will assign this issue to you.

@pcwiese
Copy link
Contributor

pcwiese commented Apr 20, 2022

@eedorenko
Is this something you can take a look at given that you added support for logs? I'm not familiar with the properties you are setting on the envelope for logs/traces. Can this be removed entirely?

@tigrannajaryan
Copy link
Member Author

@pcwiese @eedorenko will you be able to have a look at this? This is blocking a change that we need to make in the codebase. The LogRecord Name will be deleted and we can't until it is no longer referenced from anywhere.

@tigrannajaryan tigrannajaryan mentioned this issue Apr 26, 2022
Merged
@pcwiese pcwiese mentioned this issue Apr 26, 2022
Merged
@pcwiese
Copy link
Contributor

pcwiese commented Apr 26, 2022

I just commented out the use of it. I'm not sure what the replacement, if any, should be but it should not block forward progress in this repo.

tigrannajaryan added a commit to tigrannajaryan/opentelemetry-collector-contrib that referenced this issue Apr 27, 2022
@tigrannajaryan
[exporter/azuremonitor] Drop reference to obsolete LogRecord.Name
cb13e10 
LogRecord.Name is obsolete and uses of it must be removed from this repo.

Resolves
open-telemetry#9258

**Testing:**
unit testing only.
@tigrannajaryan tigrannajaryan mentioned this issue Apr 27, 2022
Closed
tigrannajaryan pushed a commit that referenced this issue Apr 29, 2022
@pcwiese
[exporter/azuremonitor] Drop reference to obsolete LogRecord.Name (#9544
220d98b 
)

LogRecord.Name is obsolete and uses of it must be removed from this repo.

Link to tracking Issue:
#9258
@tigrannajaryan
Copy link
Member Author

Resolved by #9544

djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this issue May 10, 2022
@pcwiese @djaglowski
[exporter/azuremonitor] Drop reference to obsolete LogRecord.Name (op…
9913dbf 
…en-telemetry#9544)

LogRecord.Name is obsolete and uses of it must be removed from this repo.

Link to tracking Issue:
open-telemetry#9258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcwiese pcwiese

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bogdandrutu @tigrannajaryan @pcwiese