Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate go.mod replace statements #7055

Closed
codeboten opened this issue Jan 5, 2022 · 11 comments
Closed

Automate go.mod replace statements #7055

codeboten opened this issue Jan 5, 2022 · 11 comments

Comments

@codeboten
Copy link
Contributor

Currently the replace statements for dependencies local to this repository is done manually, it would be great to automate this, as it has caused pain in the past.

This was originally suggested in the discussion below:

@codeboten not sure if the replace statements were manually added, but would be great if the tool that updates the version for these local deps also add the replacements 🗡️

Originally posted by @bogdandrutu in #7021 (review)

@bogdandrutu
Copy link
Member

@Aneurysm9 you own the go modules tool, can that be done automatically?

@Aneurysm9
Copy link
Member

There is a separate tool used by the Go API/SDK that maintains replace directives everywhere, though it currently creates replaces for all modules in all modules, regardless whether they're actually used. So, yes, it's possible and there's a tool that can help, but it could use some improvement.

@alolita
Copy link
Member

alolita commented Jan 6, 2022

@Aneurysm9 do you need additional help on making these improvements?

@Aneurysm9
Copy link
Member

Probably. I know @bryan-aguilar had expressed an interest in learning more about Go and this might be a good first project.

@bryan-aguilar
Copy link
Contributor

bryan-aguilar commented Apr 5, 2022

make crosslink is now available to automatically insert replace statements. I think this can be closed now @codeboten.

@jpkrohling
Copy link
Member

"is not", or "is now"?

@bryan-aguilar
Copy link
Contributor

Oops! Fixed! is now. I think it's time for a new keyboard! ha.

@codeboten
Copy link
Contributor Author

Can this issue remain open until crosslink is for the entire repo? Ideally this would be run in the CI as well to notify us when someone has missed replaced lines

@bryan-aguilar
Copy link
Contributor

Definitely, sounds good to me!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 8, 2022
animetauren pushed a commit to animetauren/opentelemetry-collector-contrib that referenced this issue Apr 4, 2023
…her string parts (open-telemetry#7055)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants