Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Failed test][cmd/opampsupervisor] TestSupervisorPersistsNewInstanceID randomly failed #36850

Closed
bacherfl opened this issue Dec 16, 2024 · 3 comments · Fixed by #36849
Closed

[Failed test][cmd/opampsupervisor] TestSupervisorPersistsNewInstanceID randomly failed #36850

bacherfl opened this issue Dec 16, 2024 · 3 comments · Fixed by #36849
Assignees
@bacherfl
Labels
ci-cd CI, CD, testing, build issues cmd/opampsupervisor

Comments

@bacherfl
Copy link
Contributor

Component(s)

cmd/opampsupervisor

Describe the issue you're reporting

E.g.: TestSupervisorPersistsNewInstanceID

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x9441b4]

goroutine 682 [running]:
github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor.(*Supervisor).reportConfigStatus(0xc0001938c8, 0x3, {0xa86e55, 0x1d})
	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/supervisor.go:1246 +0x54
github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor.(*Supervisor).runAgentProcess(0xc0001938c8)
	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/supervisor.go:1153 +0x85d
github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor.(*Supervisor).Start.func1()
	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/supervisor.go:240 +0x52
created by github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor.(*Supervisor).Start in goroutine 651
	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/supervisor.go:238 +0x767
exit status 2
@bacherfl bacherfl added ci-cd CI, CD, testing, build issues needs triage New item requiring triage cmd/opampsupervisor labels Dec 16, 2024
@bacherfl bacherfl self-assigned this Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for cmd/opampsupervisor: @evan-bradley @atoulme @tigrannajaryan. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@bacherfl bacherfl mentioned this issue Dec 16, 2024
Merged
@bacherfl bacherfl removed the needs triage New item requiring triage label Dec 16, 2024
@songy23
Copy link
Member

songy23 commented Dec 16, 2024

+1 https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12356389562/job/34482710393

this is TestSupervisorStartsCollectorWithRemoteConfig but with the same failure

@github-actions github-actions bot mentioned this issue Dec 17, 2024
Open
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@bacherfl @sbylica-splunk
[opampsupervisor] avoid nil pointer access when reporting remote conf…
bafe727 
…ig status (open-telemetry#36849)

#### Description

When working on an unrelated PR I noticed that one of the opamp
supervisor e2e tests was randomly failing, due to a nil pointer access -
see
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12350739300/job/34464544343?pr=36844#step:8:647
This PR avoids this by using the `GetConfigHash()` method of the
`remoteConfig` instead of directly accessing the `ConfigHash` property.

#### Link to tracking issue

Fixes open-telemetry#36850

---------

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
mterhar pushed a commit to mterhar/opentelemetry-collector-contrib that referenced this issue Dec 19, 2024
@bacherfl @mterhar
[opampsupervisor] avoid nil pointer access when reporting remote conf…
104ea3b 
…ig status (open-telemetry#36849)

#### Description

When working on an unrelated PR I noticed that one of the opamp
supervisor e2e tests was randomly failing, due to a nil pointer access -
see
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12350739300/job/34464544343?pr=36844#step:8:647
This PR avoids this by using the `GetConfigHash()` method of the
`remoteConfig` instead of directly accessing the `ConfigHash` property.

#### Link to tracking issue

Fixes open-telemetry#36850

---------

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bacherfl bacherfl

Labels
ci-cd CI, CD, testing, build issues cmd/opampsupervisor
Projects
None yet
Milestone
No milestone
2 participants
@bacherfl @songy23