[CI] Avoid toolchain updates on make gotidy runs
#35160
Assignees
Labels
ci-cd
CI, CD, testing, build issues
cmd/otelcontribcol
otelcontribcol command
cmd/oteltestbedcol
priority:p3
Lowest
Comments
mx-psi
added
priority:p3
Merged
|
@mx-psi , Can I take this one ? |
|
Sure! |
|
@mx-psi |
|
this should be fixed with #34844 |
mx-psi
pushed a commit
that referenced
this issue
Oct 1, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR adds a new `remove-toolchain` make command which removes the `toolchain` directive from all go.mod files. The new make command is also added to the `update-otel` make target. **Link to tracking Issue:** <Issue number if applicable> - fixes #33600 - could potentially also work for #35160 **Testing:** <Describe what testing was performed and which tests were added.> - add a `toolchain go1.22.5` directive to any of the go.mod files in this repo - call `make remove-toolchain` - check if the toolchain directive was removed --------- Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this issue
Oct 4, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR adds a new `remove-toolchain` make command which removes the `toolchain` directive from all go.mod files. The new make command is also added to the `update-otel` make target. **Link to tracking Issue:** <Issue number if applicable> - fixes open-telemetry#33600 - could potentially also work for open-telemetry#35160 **Testing:** <Describe what testing was performed and which tests were added.> - add a `toolchain go1.22.5` directive to any of the go.mod files in this repo - call `make remove-toolchain` - check if the toolchain directive was removed --------- Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
|
Right, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
cmd/otelcontribcol, cmd/oteltestbedcol
Describe the issue you're reporting
Recent Go versions added the
toolchaindirective to indicate the Go version suggested for use.This is annoying in that if running something like
make gotidylocally the directive will be updated to reflect the local Go version, but the local Go version may not match the CI Go version on the specific job that checks this.We could get the correct Go version from CI and manually
sedfor reverting any updates to thetoolchaindirectives.The text was updated successfully, but these errors were encountered: