-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hec_metadata_to_otel_attrs
option is confusing on exporter/splunkhec
#35092
Comments
Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Would you like to offer a PR to fix the naming? |
I could do that. Before I set out to do it, is there agreement that the naming is confusing enough that we should change it? |
Yes, I think so. As you change the name, we will want to mark the current field deprecated and keep it around for a little while, and introduce a new field. Best to discuss the name of the new field in this issue. I guess it should be |
That is what I was thinking. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
…config fields (open-telemetry#35476) **Description:** Adding a new config fields `otel_attrs_to_hec_metadata/*` to replace the `hec_metadata_to_otel_attrs/*` config fields. **Link to tracking Issue:** fixes open-telemetry#35092 **Testing:** No new tests added, modified existing tests. **Documentation:** Adding field-level description to exporter README.md.
Component(s)
exporter/splunkhec
Describe the issue you're reporting
The config option
hec_metadata_to_otel_attrs
is confusing when used with the splunkhec exporter as the actual effect is the opposite, i.e. taking otel attributes and using them as HEC metadata when sending to some destination.opentelemetry-collector-contrib/exporter/splunkhecexporter/config.go
Line 120 in bd66ceb
The text was updated successfully, but these errors were encountered: