Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hec_metadata_to_otel_attrs option is confusing on exporter/splunkhec #35092

Closed
bderrly opened this issue Sep 10, 2024 · 6 comments · Fixed by #35476
Closed

hec_metadata_to_otel_attrs option is confusing on exporter/splunkhec #35092

bderrly opened this issue Sep 10, 2024 · 6 comments · Fixed by #35476

Comments

@bderrly
Copy link
Contributor

bderrly commented Sep 10, 2024

Component(s)

exporter/splunkhec

Describe the issue you're reporting

The config option hec_metadata_to_otel_attrs is confusing when used with the splunkhec exporter as the actual effect is the opposite, i.e. taking otel attributes and using them as HEC metadata when sending to some destination.

HecToOtelAttrs splunk.HecToOtelAttrs `mapstructure:"hec_metadata_to_otel_attrs"`

@bderrly bderrly added the needs triage New item requiring triage label Sep 10, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Sep 11, 2024

Would you like to offer a PR to fix the naming?

@atoulme atoulme removed the needs triage New item requiring triage label Sep 11, 2024
@bderrly
Copy link
Contributor Author

bderrly commented Sep 13, 2024

I could do that. Before I set out to do it, is there agreement that the naming is confusing enough that we should change it?

@atoulme
Copy link
Contributor

atoulme commented Sep 13, 2024

Yes, I think so. As you change the name, we will want to mark the current field deprecated and keep it around for a little while, and introduce a new field. Best to discuss the name of the new field in this issue. I guess it should be otel_attrs_to_hec_metadata?

@bderrly
Copy link
Contributor Author

bderrly commented Sep 16, 2024

I guess it should be otel_attrs_to_hec_metadata?

That is what I was thinking.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 18, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
…config fields (open-telemetry#35476)

**Description:** Adding a new config fields
`otel_attrs_to_hec_metadata/*` to replace the
`hec_metadata_to_otel_attrs/*` config fields.

**Link to tracking Issue:** fixes open-telemetry#35092

**Testing:** No new tests added, modified existing tests.

**Documentation:** Adding field-level description to exporter README.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants