Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare components for the Client Authentication Extensions #3507

Closed
gramidt opened this issue May 24, 2021 · 1 comment
Closed

Prepare components for the Client Authentication Extensions #3507

gramidt opened this issue May 24, 2021 · 1 comment

Comments

@gramidt
Copy link
Member

gramidt commented May 24, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
open-telemetry/opentelemetry-collector#3128 in the core introduces changes to ToDialOptions and ToClient methods to use configuration from extensions to get hold of authentication configuration for clients. However, this commit has recently been rolled back to reduce the changes needed for an individual PR in contrib ( see #3442 ). This issue is to track moving the necessary code to the exporter/receiver/extenion 'Start' method to prepare for a more refined approach approach for integrating this new feature set.

Impacted components:

Exporters:

  • lokiexporter (I'm the codeowner)
  • dynatraceexporter
  • sumologicexporter
  • influxdbexporter
  • signalfxexporter
  • f5cloudexporter (I'm the codeowner)
  • awsprometheusremotewriteexporter
  • humioexporter
  • uptraceexporter

Receivers:

  • nginxreceiver

Extensions:

  • httpforwarderextension

Describe the solution you'd like
I will create individual PRs based on the individual commits from #3442, minus extensions being passed to ToClient(). I will leave the component.Host changes, so that the changes needed to re-add are extremely minimal.

Describe alternatives you've considered
N/A

Additional context
This is required based on a conversation with @bogdandrutu within #3442.
This was referenced May 24, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@gramidt
Copy link
Member Author

gramidt commented May 24, 2021

@bogdandrutu - I have split the PRs based on your feedback on #3442.

cc @jpkrohling @tigrannajaryan @pavankrish123

tigrannajaryan pushed a commit that referenced this issue May 25, 2021
@gramidt
updated awsprometheusremotewriteeexporter for upcoming client auth ex…
bb67209 
…tension changes (#3518)

While this change is mostly syntax updates, this will reduce the effort for adding the corresponding tests for Client Auth Extensions in a near future PR.

Link to tracking Issue:
#3507
thepeterstone pushed a commit to thepeterstone/opentelemetry-collector-contrib that referenced this issue May 25, 2021
@gramidt
updated awsprometheusremotewriteeexporter for upcoming client auth ex…
61cfd35 
…tension changes (open-telemetry#3518)

Updated awsprometheusremotewriteeexporter tests for upcoming client auth extension changes.

While this change is mostly syntax updates, this will reduce the effort for adding the corresponding tests for Client Auth Extensions in a near future PR.

**Link to tracking Issue:**
open-telemetry#3507
tigrannajaryan pushed a commit that referenced this issue May 25, 2021
@gramidt
[nginxreceiver] Updated for upcoming client auth extension changes (#…
2cb31f4 
…3513)

**Link to tracking Issue:**
#3507
@gramidt gramidt mentioned this issue May 27, 2021
Closed
tigrannajaryan pushed a commit that referenced this issue May 28, 2021
@gramidt
[signalfxexporter] Updated for upcoming client auth extension changes (…
63437f7 
…#3511)

Link to tracking Issue:
#3507
@gramidt gramidt closed this as completed May 28, 2021
This was referenced Jun 2, 2021
Merged
Closed
Merged
tigrannajaryan pushed a commit that referenced this issue Jun 3, 2021
@gramidt
Update core to latest and configure components for the Client Authent…
bb5f655 
…ication Extensions (2/2) (#3694)

This is the second phase of #3507.

**Link to tracking Issue:**
#3692 

Component changes are based on open-telemetry/opentelemetry-collector#3340.

Also related to open-telemetry/opentelemetry-collector#3282
alexperez52 referenced this issue in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@bogdandrutu
Move internal/pdatagrpc to model/otlpgrpc (#3507)
75ebb88 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this issue Sep 21, 2021
@gramidt
updated awsprometheusremotewriteeexporter for upcoming client auth ex…
4d083f5 
…tension changes (open-telemetry#3518)

While this change is mostly syntax updates, this will reduce the effort for adding the corresponding tests for Client Auth Extensions in a near future PR.

Link to tracking Issue:
open-telemetry#3507
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this issue Oct 1, 2021
@gramidt
updated awsprometheusremotewriteeexporter for upcoming client auth ex…
35b3168 
…tension changes (open-telemetry#3518)

While this change is mostly syntax updates, this will reduce the effort for adding the corresponding tests for Client Auth Extensions in a near future PR.

Link to tracking Issue:
open-telemetry#3507
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this issue Oct 8, 2021
@gramidt
updated awsprometheusremotewriteeexporter for upcoming client auth ex…
c4218cd 
…tension changes (open-telemetry#3518)

While this change is mostly syntax updates, this will reduce the effort for adding the corresponding tests for Client Auth Extensions in a near future PR.

Link to tracking Issue:
open-telemetry#3507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gramidt