Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having both github.com/docker/docker@v26.0.1+incompatible and github.com/google/cadvisor@v0.49.0 breaks build #33170

Closed
songy23 opened this issue May 21, 2024 · 2 comments · Fixed by #33870
Labels

Comments

@songy23
Copy link
Member

songy23 commented May 21, 2024

Component(s)

No response

Describe the issue you're reporting

See #33059 (comment)

Problem is cadvisor@v0.49.0 depends on github.com/docker/docker v24.0.9+incompatible https://github.com/google/cadvisor/blob/master/go.mod#L14 and that version does not work with the one here. Until cadvisor adopts v26.0.1+incompatible this PR cannot move forward.

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9179574250/job/25242203890?pr=33159#step:8:18

Error: /home/runner/go/pkg/mod/github.com/google/cadvisor@v0.49.0/container/docker/utils/docker.go:48:42: undefined: dockertypes.Info
Error: /home/runner/go/pkg/mod/github.com/google/cadvisor@v0.49.0/container/docker/utils/docker.go:57:44: undefined: dockertypes.Info
Error: /home/runner/go/pkg/mod/github.com/google/cadvisor@v0.49.0/container/docker/utils/docker.go:77:43: undefined: dockertypes.Info
Error: /home/runner/go/pkg/mod/github.com/google/cadvisor@v0.49.0/container/docker/utils/docker.go:86:48: undefined: dockertypes.ImageSummary

Affected dependency PRs:

Copy link
Contributor

Pinging code owners for exporter/clickhouse: @hanjm @dmitryax @Frapschen @SpencerTorres. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

Pinging code owners for receiver/prometheus: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@frzifus frzifus removed the needs triage New item requiring triage label May 22, 2024
@songy23 songy23 added the help wanted Extra attention is needed label Jun 25, 2024
jefchien pushed a commit to amazon-contributing/opentelemetry-collector-contrib that referenced this issue Oct 30, 2024
Fixes open-telemetry#33170

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants