Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deltatocumulative aborts after first sample #31350

Closed
sh0rez opened this issue Feb 20, 2024 · 2 comments · Fixed by #31349
Closed

deltatocumulative aborts after first sample #31350

sh0rez opened this issue Feb 20, 2024 · 2 comments · Fixed by #31349
Labels
bug Something isn't working processor/deltatocumulative

Comments

@sh0rez
Copy link
Member

sh0rez commented Feb 20, 2024 •
edited
Loading

Component(s)

processor/deltatocumulative

What happened?

Description

deltatocumulativeprocessor only updates the first sample of each stream

Steps to Reproduce

send a stream with more than two samples

Expected Result

all samples are converted to cumulative

Actual Result

only first sample is converted

Collector version

d4dda61
@sh0rez sh0rez added bug Something isn't working needs triage New item requiring triage labels Feb 20, 2024
@sh0rez sh0rez mentioned this issue Feb 20, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for processor/deltatocumulative: @sh0rez @RichieSams. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Issue filed by a code owner, and the other code owner has approved the PR, so I'm removing needs triage.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Feb 26, 2024
djaglowski pushed a commit that referenced this issue Feb 26, 2024
@sh0rez
[processor/deltatocumulative]: bugfix - process all samples (#31349)
3c97c8f 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Due to an oversight, the processor stopped after the first sample. It
should process all available samples per stream.

**Testing:**
Tests have been added to verify:
- `Samples()` visits all samples
- `Aggregate()` edits all samples

**Issues**
Fixes
#31350
This was referenced Feb 27, 2024
Closed
Open
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
@sh0rez @XinRanZhAWS
[processor/deltatocumulative]: bugfix - process all samples (open-tel…
db8dc34 
…emetry#31349)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Due to an oversight, the processor stopped after the first sample. It
should process all available samples per stream.

**Testing:**
Tests have been added to verify:
- `Samples()` visits all samples
- `Aggregate()` edits all samples

**Issues**
Fixes
open-telemetry#31350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working processor/deltatocumulative
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[processor/deltatocumulative]: bugfix - process all samples sh0rez/opentelemetry-collector-contrib
2 participants
@sh0rez @crobert-1