Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flaky test][pkg/stanza] Fileconsumer rotation tests timing out #30836

Closed
crobert-1 opened this issue Jan 29, 2024 · 2 comments · Fixed by #31298
Closed

[flaky test][pkg/stanza] Fileconsumer rotation tests timing out #30836

crobert-1 opened this issue Jan 29, 2024 · 2 comments · Fixed by #31298

Comments

@crobert-1
Copy link
Member

Component(s)

pkg/stanza

Describe the issue you're reporting

Failing test link - Occurred on a PR with unrelated changes.

Running target 'test-with-cover' in module 'pkg/stanza' as part of group 'pkg'
make -C pkg/stanza test-with-cover
make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza'
mkdir -p /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit
go test -race -timeout 300s -parallel 4 --tags="" -cover ./... -covermode=atomic -args -test.gocoverdir="/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit"
go: downloading github.com/observiq/nanojack v0.0.0-20201106172433-34392[88](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7632088000/job/20791639959?pr=30709#step:9:89)47ebc
?   	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/attrs	[no test files]
?   	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/decode	[no test files]
?   	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/emit	[no test files]
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/adapter	11.807s	coverage: 76.6% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/entry	0.049s	coverage: 90.8% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/errors	0.027s	coverage: 100.0% of statements
?   	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/operatortest	[no test files]
?   	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/output/file	[no test files]
?   	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/testutil	[no test files]
--- FAIL: TestRotation (31.77s)
    --- FAIL: TestRotation/Deletion/CopyTruncateSequential (30.05s)
        sink.go:93: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:93
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:70
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/rotation_test.go:295
            	Error:      	Timed out waiting for message
            	Test:       	TestRotation/Deletion/CopyTruncateSequential
        sink.go:93: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:93
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:70
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/rotation_test.go:295
            	Error:      	Timed out waiting for message
            	Test:       	TestRotation/Deletion/CopyTruncateSequential
        sink.go:93: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:93
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:70
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/rotation_test.go:295
            	Error:      	Timed out waiting for message
            	Test:       	TestRotation/Deletion/CopyTruncateSequential
        sink.go:93: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:93
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:70
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/rotation_test.go:295
            	Error:      	Timed out waiting for message
            	Test:       	TestRotation/Deletion/CopyTruncateSequential
        sink.go:93: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:93
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:70
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/rotation_test.go:295
            	Error:      	Timed out waiting for message
            	Test:       	TestRotation/Deletion/CopyTruncateSequential
        sink.go:93: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:93
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:70
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/rotation_test.go:295
            	Error:      	Timed out waiting for message
            	Test:       	TestRotation/Deletion/CopyTruncateSequential
        sink.go:93: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:93
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:70
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/rotation_test.go:295
            	Error:      	Timed out waiting for message
            	Test:       	TestRotation/Deletion/CopyTruncateSequential
        sink.go:93: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:93
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:70
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/rotation_test.go:295
            	Error:      	Timed out waiting for message
            	Test:       	TestRotation/Deletion/CopyTruncateSequential
        sink.go:93: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:93
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:70
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/rotation_test.go:295
            	Error:      	Timed out waiting for message
            	Test:       	TestRotation/Deletion/CopyTruncateSequential
        sink.go:93: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:93
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest/sink.go:70
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/rotation_test.go:295
            	Error:      	Timed out waiting for message
            	Test:       	TestRotation/Deletion/CopyTruncateSequential
        rotation_test.go:301: Potentially unstable ephemerality expectation for test: Deletion
        rotation_test.go:303: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/rotation_test.go:303
            	Error:      	[][]uint8{[]uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x20, 0x30}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x20, 0x31}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x20, 0x32}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x20, 0x33}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x20, 0x34}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x20, 0x35}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x20, 0x36}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x20, 0x37}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x20, 0x38}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x20, 0x39}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x31, 0x30}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x31, 0x31}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x31, 0x32}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x31, 0x33}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x31, 0x34}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x31, 0x35}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x31, 0x36}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x31, 0x37}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x31, 0x38}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x31, 0x39}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x32, 0x30}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x32, 0x31}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x32, 0x32}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x32, 0x33}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x32, 0x34}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x32, 0x35}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x32, 0x36}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x32, 0x37}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x32, 0x38}, []uint8{0x7a, 0x6c, 0x79, 0x65, 0x73, 0x66, 0x64, 0x65, 0x6b, 0x67, 0x79, 0x61, 0x63, 0x6d, 0x73, 0x65, 0x62, 0x6c, 0x76, 0x70, 0x6d, 0x75, 0x6a, 0x76, 0x76, 0x6e, 0x6e, 0x6a, 0x70, 0x71, 0x6e, 0x66, 0x74, 0x62, 0x65, 0x67, 0x61, 0x78, 0x67, 0x72, 0x61, 0x68, 0x72, 0x75, 0x6e, 0x61, 0x20, 0x20, 0x32, 0x39}} does not contain []byte(nil)
            	Test:       	TestRotation/Deletion/CopyTruncateSequential
FAIL
	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer	coverage: 88.3% of statements
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer	47.627s
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/attrs	0.033s	coverage: 90.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/checkpoint	0.033s	coverage: 83.3% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/emittest	0.299s	coverage: 100.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/fileset	0.041s	coverage: 95.5% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/filetest	0.019s	coverage: 0.0% of statements [no tests to run]
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/fingerprint	1.221s	coverage: 95.8% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/header	0.043s	coverage: [89](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7632088000/job/20791639959?pr=30709#step:9:90).5% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/reader	0.352s	coverage: 70.2% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/scanner	0.034s	coverage: 100.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/trie	0.033s	coverage: 97.1% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/internal/util	0.065s	coverage: 100.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/matcher	0.112s	coverage: 98.3% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/matcher/internal/filter	0.083s	coverage: 97.8% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/matcher/internal/finder	0.046s	coverage: 100.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/flush	0.259s	coverage: 84.6% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator	0.030s	coverage: 65.5% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/helper	0.671s	coverage: 82.6% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/input/file	0.883s	coverage: [90](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7632088000/job/20791639959?pr=30709#step:9:91).3% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/input/generate	0.040s	coverage: 65.9% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/input/journald	0.032s	coverage: 80.4% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/input/namedpipe	0.082s	coverage: 80.2% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/input/stdin	0.034s	coverage: 79.4% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/input/syslog	0.068s	coverage: 84.6% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/input/tcp	0.713s	coverage: 78.9% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/input/udp	0.964s	coverage: 81.9% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/input/windows	0.043s	coverage: 94.6% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/output/drop	0.023s	coverage: 87.5% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/output/stdout	0.023s	coverage: 60.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/csv	1.886s	coverage: 96.5% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/json	0.056s	coverage: 100.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/jsonarray	1.542s	coverage: 86.1% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/keyvalue	0.042s	coverage: 97.5% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex	2.071s	coverage: 90.7% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/scope	0.035s	coverage: 88.9% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/severity	0.058s	coverage: 75.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/syslog	0.042s	coverage: 87.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/time	0.070s	coverage: 100.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/trace	0.033s	coverage: 90.9% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/uri	0.055s	coverage: 100.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/add	0.054s	coverage: 87.1% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/assignkeys	0.031s	coverage: 77.1% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/copy	0.044s	coverage: 82.4% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/filter	0.036s	coverage: 68.8% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/flatten	0.049s	coverage: 76.7% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/move	0.058s	coverage: 80.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/noop	0.039s	coverage: 80.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/recombine	0.3[92](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7632088000/job/20791639959?pr=30709#step:9:93)s	coverage: 89.8% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/remove	0.063s	coverage: 63.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/retain	0.033s	coverage: 92.3% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/router	0.050s	coverage: 68.3% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/unquote	0.045s	coverage: 94.4% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/pipeline	0.071s	coverage: [93](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7632088000/job/20791639959?pr=30709#step:9:94).5% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/split	0.060s	coverage: 97.7% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/split/splittest	0.139s	coverage: 90.0% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/trim	0.021s	coverage: [96](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7632088000/job/20791639959?pr=30709#step:9:97).4% of statements
FAIL
make[2]: *** [../../Makefile.Common:[125](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7632088000/job/20791639959?pr=30709#step:9:126): test-with-cover] Error 1
make[2]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza'
make[1]: *** [Makefile:[152](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7632088000/job/20791639959?pr=30709#step:9:153): pkg/stanza] Error 2
@crobert-1 crobert-1 added the needs triage New item requiring triage label Jan 29, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

Pinging code owners for receiver/filelog: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

djaglowski added a commit that referenced this issue Feb 21, 2024
Resolves
#30836

Also removes a dependency on `observIQ/nanojack` by simplifying rotation
tests. We still test both move/create and copy/truncate strategies, but
the unit tests are managing rotated files manually. We are no longer
testing rotation based on different naming strategies since this is
effectively just a matching problem, which is well tested elsewhere.
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
Resolves
open-telemetry#30836

Also removes a dependency on `observIQ/nanojack` by simplifying rotation
tests. We still test both move/create and copy/truncate strategies, but
the unit tests are managing rotated files manually. We are no longer
testing rotation based on different naming strategies since this is
effectively just a matching problem, which is well tested elsewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants