Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples for clickhouse exporter are broken #30159

Closed
neyguvj opened this issue Dec 21, 2023 · 2 comments · Fixed by #30161
Closed

examples for clickhouse exporter are broken #30159

neyguvj opened this issue Dec 21, 2023 · 2 comments · Fixed by #30161
Labels
bug Something isn't working exporter/clickhouse

Comments

@neyguvj
Copy link

neyguvj commented Dec 21, 2023

Component(s)

exporter/clickhouse

What happened?

Description

There is an error in clickhouseexporter makefile go build command.

Also tracegen was removed from the repository. It needs to be replaced with telemetrygen.

Steps to Reproduce

Run the following commands

cd exporter/clickhouseexporter
make local-run-example

Expected Result

all containers are running.

Actual Result

Got error:

cd ../../ && GOOS=linux go build -o ./local/otelcontribcol ./cmd/otelcontribcol
main module (github.com/open-telemetry/opentelemetry-collector-contrib) does not contain package github.com/open-telemetry/opentelemetry-collector-contrib/cmd/otelcontribcol
make: *** [Makefile:4: local-run-example] Error 1

After fixing the Makefile I still get the error

cd ../../ && GOOS=linux go build -o ../../local/otelcontribcol  -C cmd/otelcontribcol
cd example && docker-compose up -d
ERROR: build path /home/golov-rg/work/cloud/opentelemetry-collector-contrib/cmd/tracegen either does not exist, is not accessible, or is not a valid URL.
make: *** [Makefile:5: local-run-example] Error 1

Collector version

2008304

Environment information

Environment

OS: Ubuntu 22.04
Compiler: go 1.20.9

OpenTelemetry Collector configuration

``

Log output

No response

Additional context

No response
@neyguvj neyguvj added bug Something isn't working needs triage New item requiring triage labels Dec 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 mentioned this issue Dec 21, 2023
Merged
@crobert-1
Copy link
Member

I was able to confirm it's broken, and I've submitted a fix PR.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Dec 21, 2023
bogdandrutu pushed a commit that referenced this issue Dec 21, 2023
@crobert-1
[chore][exporter/clickhouse] Fix broken makefile command for examples (…
dc787b6 
…#30161)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The ClickHouse exporter contains a docker example with `telemetrygen`
generating traces to send to the otel collector, which then sends to the
ClickHouse backend. Grafana is then used to view traces. The make
commands were broken due being in the wrong directory when executing, as
well as the deprecation of `tracegen` in favor of `telemetrygen traces`.

**Link to tracking Issue:** <Issue number if applicable>
Resolves #30159

**Testing:** <Describe what testing was performed and which tests were
added.>
Both `make` commands are working and everything's up and running. Also
confirmed `telemetrygen` is properly sending traces to the collector.
Note: I'm not familiar enough with Grafana or ClickHouse to be able to
validate clickhouse exporter functionality in the example. A code owner
or user will have to verify the example still works.
@github-actions github-actions bot mentioned this issue Dec 26, 2023
Closed
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
@crobert-1 @cparkins
[chore][exporter/clickhouse] Fix broken makefile command for examples (…
5530feb 
…open-telemetry#30161)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The ClickHouse exporter contains a docker example with `telemetrygen`
generating traces to send to the otel collector, which then sends to the
ClickHouse backend. Grafana is then used to view traces. The make
commands were broken due being in the wrong directory when executing, as
well as the deprecation of `tracegen` in favor of `telemetrygen traces`.

**Link to tracking Issue:** <Issue number if applicable>
Resolves open-telemetry#30159

**Testing:** <Describe what testing was performed and which tests were
added.>
Both `make` commands are working and everything's up and running. Also
confirmed `telemetrygen` is properly sending traces to the collector.
Note: I'm not familiar enough with Grafana or ClickHouse to be able to
validate clickhouse exporter functionality in the example. A code owner
or user will have to verify the example still works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working exporter/clickhouse
Projects
None yet
Milestone
No milestone
2 participants
@neyguvj @crobert-1