Telemetrygen fails to parse ip for otlp-endpoint provided

[asreehari-splunk]

Component(s)

cmd/telemetrygen

What happened?

Description

We've used this tool to generate load in the recent past but when we tried this last week with the following command, the tool complained that parsing the IP and port failed

telemetrygen traces --duration 30m --otlp-endpoint 127.0.1.1:8080 --otlp-header "X-SF-Token=\"MyToken\"" --otlp-header "Content-Type"="\"application/x-protobuf\"" --workers 3 --otlp-insecure true --rate 6000

Steps to Reproduce

Expected Result

To send traffic like it did before

Actual Result

2023-09-08T08:48:38.590-0700 INFO grpc@v1.57.0/clientconn.go:1791 [core][Channel #1] dial target "127.0.1.1:8080" parse failed: parse "127.0.1.1:8080": first path segment in URL cannot contain colon {"system": "grpc", "grpc_log": true}

Collector version

latest

Environment information

Environment

OS: Mac OSx Ventura
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

2023-09-08T08:48:38.590-0700	INFO	grpc@v1.57.0/clientconn.go:1791	[core][Channel #1] dial target "127.0.1.1:8080" parse failed: parse "127.0.1.1:8080": first path segment in URL cannot contain colon	{"system": "grpc", "grpc_log": true}

Additional context

.

[github-actions]

Pinging code owners:

• cmd/telemetrygen: @mx-psi @codeboten

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[codeboten]

I see the same error, but my traffic is still being sent, can you confirm whether or not that happens in your case as well? The address shown in the example above is 127.0.1.1, did you mean to use to use 127.0.0.1?

[asreehari-splunk]

No. In my case, I do not see traffic being sent either. That ip address ( 127.0.1.1) is just an example. I've scrubbed the actual ip address i am trying to send data to. I additionally see this log as well. Not sure if it helps ``` 2023-09-12T14:02:39.484-0700 INFO ***@***.***/clientconn.go:1807 [core][Channel #1] fallback to scheme "passthrough" {"system": "grpc", "grpc_log": true} ```

…

On Tue, Sep 12, 2023 at 1:39 PM Alex Boten ***@***.***> wrote: [ External sender. Exercise caution. ] I see the same error, but my traffic is still being sent, can you confirm whether or not that happens in your case as well? The address shown in the example above is 127.0.1.1, did you mean to use to use 127.0.0.1? — Reply to this email directly, view it on GitHub <#26659 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARX2CBIUISQM4FCZV4JTBXDX2DB55ANCNFSM6AAAAAA4VFSOU4> . You are receiving this because you authored the thread.Message ID: <open-telemetry/opentelemetry-collector-contrib/issues/26659/1716395433@ github.com>

[atoulme]

I will work on this with adding an integration test first.

[atoulme]

It appears this issue is not blocking telemetrygen. The error message is misleading. Adding the scheme passthrough to the endpoint helps: passthrough:///192.168.0.1:9080

[atoulme]

After a bit of research, it appears we specifically disable warn logging for the collector as info is deemed chatty. I think we can do that as well here, as logs emitted at info level by grpc are causing confusion.

See https://github.com/open-telemetry/opentelemetry-collector/blob/e116f8c928eb49ba6816751397f5e9e3cf867856/otelcol/internal/grpclog/logger.go#L15C9-L15C53 for how we mirror the behavior of setting the grpc logger.

[asreehari-splunk]

@antoine Toulme ***@***.***> After updating to the latest per your recommendation, I did not need the "passthrough" prefix and the load gen worked as expected. I do see that parsing error message but it was just information and did not affect functionality.

…

On Fri, Sep 22, 2023 at 9:35 AM Antoine Toulme ***@***.***> wrote: [ External sender. Exercise caution. ] After a bit of research, it appears we specifically disable warn logging for the collector as info is deemed chatty. I think we can do that as well here, as logs emitted at info level by grpc are causing confusion. See https://github.com/open-telemetry/opentelemetry-collector/blob/e116f8c928eb49ba6816751397f5e9e3cf867856/otelcol/internal/grpclog/logger.go#L15C9-L15C53 for how we mirror the behavior of setting the grpc logger. — Reply to this email directly, view it on GitHub <#26659 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARX2CBKJOOEHOOVP7NYVWQDX3W46NANCNFSM6AAAAAA4VFSOU4> . You are receiving this because you authored the thread.Message ID: <open-telemetry/opentelemetry-collector-contrib/issues/26659/1731717763@ github.com>

[atoulme]

Right, there was no bug in the behavior, but this log was misleading. Excluding this class of logs makes sense to reduce confusion, and we have done so now.