-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
receiver/k8scluster: Use OTel conventions for metadata #2530
Merged
bogdandrutu
merged 1 commit into
open-telemetry:main
from
asuresh4:k8sclusterreceiver-conventions
Mar 3, 2021
Merged
receiver/k8scluster: Use OTel conventions for metadata #2530
bogdandrutu
merged 1 commit into
open-telemetry:main
from
asuresh4:k8sclusterreceiver-conventions
Mar 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2530 +/- ##
==========================================
+ Coverage 91.05% 91.06% +0.01%
==========================================
Files 417 417
Lines 20935 20937 +2
==========================================
+ Hits 19063 19067 +4
+ Misses 1408 1407 -1
+ Partials 464 463 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asuresh4
force-pushed
the
k8sclusterreceiver-conventions
branch
from
March 3, 2021 18:38
290f508
to
9f79731
Compare
jrcamp
approved these changes
Mar 3, 2021
This was referenced Mar 15, 2021
kisieland
referenced
this pull request
in kisieland/opentelemetry-collector-contrib
Mar 16, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Updates to metadata.
kubernetes_service_
prefix on service name in Pod metadata withk8s.service.
Testing: Updated tests.