Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/azuremonitorreceiver] Consider reducing Go API #24850

Closed
atoulme opened this issue Aug 3, 2023 · 8 comments · Fixed by #30224
Closed

[receiver/azuremonitorreceiver] Consider reducing Go API #24850

atoulme opened this issue Aug 3, 2023 · 8 comments · Fixed by #30224

Comments

@atoulme
Copy link
Contributor

atoulme commented Aug 3, 2023

Component(s)

receiver/azuremonitor

Describe the issue you're reporting

The current Go API exposes the following items:

{
  "structs": [
    "ArmClient",
    "Config",
    "MetricsDefinitionsClientInterface",
    "MetricsValuesClient"
  ],
  "functions": [
    {
      "name": "NewFactory",
      "receiver": "",
      "return_types": [
        "receiver.Factory"
      ]
    }
  ]
}

Are any of those elements a good target to be unexported?

@atoulme atoulme added the needs triage New item requiring triage label Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mwear
Copy link
Member

mwear commented Aug 3, 2023

@altuner any chance you can put this on your todo list?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • needs: Github issue template generation code needs this to generate the corresponding labels.
  • receiver/azuremonitor: @altuner @codeboten

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 3, 2023
@altuner
Copy link
Contributor

altuner commented Oct 3, 2023

@altuner any chance you can put this on your todo list?

Sure, will add this into my list

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@nslaughter
Copy link
Contributor

/label receiver/azuremonitor -stale

Copy link
Contributor

Pinging code owners for receiver/azuremonitor: @altuner @codeboten. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mwear mwear removed the Stale label Dec 28, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants