-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI testing for metadata.yaml for receivers metrics. #23375
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
….yaml While working on open-telemetry#23375, the test looks for all `metadata.yaml` files in the receiver folder. This `metadata.yaml` file is not the one that is used for [mdatagen](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/cmd/mdatagen). I could use an allowlist to ignore this specific `metadata.yaml`, but it doesn't seem necessary for it to have the `metadata.yaml` name, so I am proposing renaming it to `metrics.yaml`.
….yaml (#24011) **Description:** While working on #23375, the test looks for all `metadata.yaml` files in the receiver folder. This `metadata.yaml` file is not the one that is used for [mdatagen](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/cmd/mdatagen). I could use an allowlist to ignore this specific `metadata.yaml`, but it doesn't seem necessary for it to have the `metadata.yaml` name, so I am proposing renaming it to `metrics.yaml`. Co-authored-by: Yang Song <songy23@users.noreply.github.com>
This PR adds a unit test to check for metric collisions in receivers which have metrics defined. Issue: open-telemetry#23375
Blocked by #26499 |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
cmd/mdatagen
Describe the issue you're reporting
The proposal is that for receivers, the CI test will check:
The text was updated successfully, but these errors were encountered: