Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI testing for metadata.yaml for receivers metrics. #23375

Closed
Tracked by #23335
mackjmr opened this issue Jun 14, 2023 · 4 comments
Closed
Tracked by #23335

Add CI testing for metadata.yaml for receivers metrics. #23375

mackjmr opened this issue Jun 14, 2023 · 4 comments
Assignees

Comments

@mackjmr
Copy link
Member

mackjmr commented Jun 14, 2023

Component(s)

cmd/mdatagen

Describe the issue you're reporting

The proposal is that for receivers, the CI test will check:

  • That there is no metric collision between receivers.
@mackjmr mackjmr added the needs triage New item requiring triage label Jun 14, 2023
@github-actions github-actions bot added the cmd/mdatagen mdatagen command label Jun 14, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@songy23 songy23 removed the needs triage New item requiring triage label Jun 14, 2023
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Jul 6, 2023
….yaml

While working on open-telemetry#23375, the test looks for all `metadata.yaml` files in the receiver folder. This `metadata.yaml` file is not the one that is used for [mdatagen](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/cmd/mdatagen). I could use an allowlist to ignore this specific `metadata.yaml`, but it doesn't seem necessary for it to have the `metadata.yaml` name, so I am proposing renaming it to `metrics.yaml`.
dmitryax pushed a commit that referenced this issue Jul 18, 2023
….yaml (#24011)

**Description:**
While working on #23375, the test looks for all `metadata.yaml` files in
the receiver folder. This `metadata.yaml` file is not the one that is
used for
[mdatagen](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/cmd/mdatagen).
I could use an allowlist to ignore this specific `metadata.yaml`, but it
doesn't seem necessary for it to have the `metadata.yaml` name, so I am
proposing renaming it to `metrics.yaml`.

Co-authored-by: Yang Song <songy23@users.noreply.github.com>
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Jul 19, 2023
This PR adds a unit test to check for metric collisions in receivers which have metrics defined.

Issue: open-telemetry#23375
@mackjmr
Copy link
Member Author

mackjmr commented Sep 7, 2023

Blocked by #26499

Copy link
Contributor

github-actions bot commented Nov 7, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 7, 2023
Copy link
Contributor

github-actions bot commented Jan 6, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants