-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metricstransformprocessor] convert resource attributes to metric labels #1297
Labels
enhancement
New feature or request
Comments
Related to or a duplicate of open-telemetry/opentelemetry-collector#1892 |
This feature is implemented in the |
dyladan
referenced
this issue
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
* Allow partial retries in queued retry processor Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Rename consumererror file Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Fix data race Signed-off-by: Pavol Loffay <ploffay@redhat.com>
ljmsc
referenced
this issue
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
codeboten
pushed a commit
that referenced
this issue
Nov 23, 2022
* Update package metadata * Update instrumentation/opentelemetry-instrumentation-starlette/pyproject.toml Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
When we gather metrics in the receiver, we set some resource attributes as well as metric labels based on the data definition. While sending these metrics to destination (AWS CloudWatch), some of the resource attributes should be converted to metric dimensions. However, it's not common that all exporters will read resource attributes to set them as metric dimensions. So, we need some kind of mechanism in the processor to convert the resource attributes to metric labels and I feel
metricstransform
processor is a good candidate for it.Describe the solution you'd like
For our use case, one boolean settings in the processor is good enough. Like
convert_resource_attributes_to_labels=true
will convert all the resource attributes to metric labels and apply them to all metrics. However, for giving more custom settings like select specific metrics and specific resource attributes, we can consider extending theadd_label
operation.Describe alternatives you've considered
In our receiver, we can set all the resource attributes as metric labels also. Here is a PR [#1284] open but the reviewer raised concerns.
The text was updated successfully, but these errors were encountered: