Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/loki] Deprecate the format option, remove the "body" encoding #12897

Closed
jpkrohling opened this issue Aug 2, 2022 · 0 comments · Fixed by #12900
Closed

[exporter/loki] Deprecate the format option, remove the "body" encoding #12897

jpkrohling opened this issue Aug 2, 2022 · 0 comments · Fixed by #12900
Assignees
@jpkrohling
Labels
comp:grafanalabs Grafana Labs components - Loki, Grafana

Comments

@jpkrohling
Copy link
Member

jpkrohling commented Aug 2, 2022 •
edited
Loading

I would like to remove the "format" attribute. It's rarely the right thing to do, with the JSON encoding being the recommended one.

Before deprecating and eventually removing it, I would like to hear about use cases from the current users of the Loki Exporter. The current plan is to deprecate this option by v0.57.0, removing it by v0.60.0.

Relates to #12873, but I split this from that as we should be able to do it right now without further refactoring.
@jpkrohling jpkrohling added the comp:grafanalabs Grafana Labs components - Loki, Grafana label Aug 2, 2022
@jpkrohling jpkrohling self-assigned this Aug 2, 2022
@jpkrohling jpkrohling mentioned this issue Aug 2, 2022
Merged
jpkrohling referenced this issue in jpkrohling/opentelemetry-collector-contrib Aug 3, 2022
@jpkrohling
[exporter/loki] Deprecate the format option
d7aec82 
Fixes #12897

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling added a commit that referenced this issue Aug 3, 2022
@jpkrohling
[exporter/loki] Deprecate the format option (#12900)
240f235 
* [exporter/loki] Deprecate the format option

Fixes #12897

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Remove format from the default config

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Clean up left over

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpkrohling jpkrohling

Labels
comp:grafanalabs Grafana Labs components - Loki, Grafana
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[exporter/loki] Deprecate the format option jpkrohling/opentelemetry-collector-contrib
1 participant
@jpkrohling