-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent way to specify metric source #1099
Comments
As far as I can tell we're not setting instrumentation library name or version for metrics that we're emitting from the collector (ie hostmetricsreceiver, redis, etc. vs metrics passing through that were generated in some other source). Perhaps these should set instr. library name and version? Are there any conventions around the name? Didn't see any in the spec. One option: Name: opentelemetry-collector/${RECEIVER_NAME} In the spec above it says attributes may be added at some point, which I think is the ideal place for the receiver name to live with name just being opentelemetry-collector (or similar). |
I agree with @jrcamp . I makes sense to keep that info in metrics instrumentationLibrary. @bogdandrutu @tigrannajaryan do you have any thoughts on this? |
Is this about Collector's self metrics? I am not sure I understand. |
It can be helpful for support purposes to know who the emitter of the metrics are and what version of it is sending. Maybe you have redis metrics coming from a Prometheus exporter that have been renamed to be the same as the redis metrics from the redis receiver you might want to be able to differentiate between them. Or for just metrics coming from the redis receiver maybe there was a bug in 1.1 that was fixed in 1.1.1. Being able to know the version of the emitter can be very helpful. |
#1099) * Bump google.golang.org/grpc from 1.31.0 to 1.31.1 in /exporters/stdout Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.0 to 1.31.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.31.0...v1.31.1) Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This issue has been inactive for 60 days. It will be closed in 120 days if there is no activity. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Is your feature request related to a problem? Please describe.
It would be great to have a consistent way to specify a source (receiver) of collected metrics. For example, kubeletstats receiver uses "receiver" resource label for that https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/master/receiver/kubeletstatsreceiver/kubelet/metrics.go#L51 . But I don't see any other receivers doing it.
Describe the solution you'd like
It seems pretty useful to have metrics source information, so would be nice to come up with a unified way of doing that.
Describe alternatives you've considered
We can decide that it's not needed, then we should remove it from kubeletstats receiver
The text was updated successfully, but these errors were encountered: