Leverage boms for transient core deps #652
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this as an example of renovate updating the core lib versions before the instrumentation versions are updated: #630 (comment)
This opens a window during which our instrumentation dep could be misaligned with our core dep. This change now forces the use of boms at the instrumentation level in order to determine which versions of the core libs to use.
Because we no longer explicitly declare which version of the core libs (api/sdk) we use in the
libs.versions.tomlfile, we have to grep for it at release time via./gradlew android-agent:dependencies.