Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose additional disk buffering configuration #596

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Expose additional disk buffering configuration #596

merged 2 commits into from
Sep 17, 2024

Conversation

breedx-splk
Copy link
Contributor

Because one size can't necessarily fit all, we need to expose additional settings for the disk buffering feature.

  • maxFileAgeForWriteMillis
  • minFileAgeForReadMillis
  • maxFileAgeForReadMillis

These map over directly to the same configurations in the contrib module, and use the same sane defaults as well.

@breedx-splk breedx-splk requested a review from a team September 13, 2024 22:41
LikeTheSalad
LikeTheSalad approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@LikeTheSalad LikeTheSalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@breedx-splk breedx-splk merged commit 91cac19 into open-telemetry:main Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@LikeTheSalad LikeTheSalad LikeTheSalad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@breedx-splk @marandaneto @LikeTheSalad