Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpURLConnection instrumentation migration to AutoService API #592

Conversation

surbhiia
Copy link
Contributor

@surbhiia surbhiia commented Sep 12, 2024

This PR migrates HttpURL instrumentation to utilize the AndroidInstrumentation AutoService interface for install and config. (This would also resolve issue #418 )

Also, moved HttpURL Tests to use the new OpentelemetryRumRule.

@surbhiia surbhiia requested a review from a team September 12, 2024 17:47
@surbhiia surbhiia changed the title Develop/http url connection migration to auto service api HttpURLConnection instrumentation migration to AutoService API Sep 12, 2024
Copy link
Contributor

@LikeTheSalad LikeTheSalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is looking much nicer with the APIs. Hooray! 🥳

@breedx-splk breedx-splk merged commit b06f4f9 into open-telemetry:main Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants