Demo app: Recommendations #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
reviewed
Aug 23, 2024
demo-app/src/main/java/io/opentelemetry/android/demo/clients/RecommendationService.kt
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Aug 23, 2024
demo-app/src/main/java/io/opentelemetry/android/demo/clients/RecommendationService.kt
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Aug 23, 2024
demo-app/src/main/java/io/opentelemetry/android/demo/clients/RecommendationService.kt
Show resolved
Hide resolved
breedx-splk
reviewed
Aug 23, 2024
demo-app/src/main/java/io/opentelemetry/android/demo/ui/shop/products/ProductList.kt
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Aug 23, 2024
…bled untill all fields aren't blank. Added kotlin.reflect to dependencies in order to check if all fields of a data class aren't blank.
…ct details and checkout info screens
…ren't selected and aren't in a cart (like in the desktop demo)
…mmedation service to avoid passing lists of products around
…ional argument of getRecommendedProducts
magda-woj
force-pushed
the
recommendations
branch
from
20e7e1c
to
caf5dde
Compare
breedx-splk
reviewed
Aug 26, 2024
demo-app/src/main/java/io/opentelemetry/android/demo/clients/RecommendationService.kt
Outdated
Show resolved
Hide resolved
LikeTheSalad
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple recommendation service based on the web demo was implemented: recommended products appear on the product details and cart screen. Additionally, a "go back" arrow button was added to the product details and the checkout-info screen that allows to successfully navigate up.
