Running android tests as part of daily checks #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof, this adds 23 minutes to the build! Are we ok with that? |
That seems quite a long time, especially considering that we don't have many android tests right now. I've just moved it to the daily build checks as I don't think it's necessary for now to run these on every PR, it would have been nice though, but based on the numbers we saw here I think it's not worth waiting that long unless it becomes really necessary in the future. |
LikeTheSalad
changed the title
breedx-splk
approved these changes
Aug 8, 2024
|
Yeah, might be nice down the road to understand where the time is being spent. It does seem excessive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #501