-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a integer spin box that allows too choose quantity of a product… #507
Added a integer spin box that allows too choose quantity of a product… #507
Conversation
This was also an amusing read: https://rmirabelle.medium.com/there-is-no-material-design-spinner-for-android-3261b7c77da8 🙃 |
@magda-woj do you know if the demo web client version allows choosing more than 10 items? |
for (i in 1..10) { | ||
DropdownMenuItem( | ||
text = { | ||
Row( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think we should (whenever possible) try to split big widgets into multiple composable functions to avoid "indentation hell".
… added to cart - range from 1 to 10, like on the otel demo astronomy shop website.
…it should be in the center?), split up QuantityChooser into a few composables.
57fa6f4
to
9e7129c
Compare
@breedx-splk web client version also allows to choose from 1 to 10, that's why i did it like that here. |
… added to cart - range from 1 to 10, like on the otel demo astronomy shop website.