Added a integer spin box that allows too choose quantity of a product… #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The number itself is oddly wide, but I think it's fine for now. Thanks! |
breedx-splk
approved these changes
Aug 5, 2024
|
This was also an amusing read: https://rmirabelle.medium.com/there-is-no-material-design-spinner-for-android-3261b7c77da8 🙃 |
|
@magda-woj do you know if the demo web client version allows choosing more than 10 items? |
LikeTheSalad
reviewed
Aug 6, 2024
| for (i in 1..10) { | ||
| DropdownMenuItem( | ||
| text = { | ||
| Row( |
There was a problem hiding this comment.
nit: I think we should (whenever possible) try to split big widgets into multiple composable functions to avoid "indentation hell".
LikeTheSalad
approved these changes
Aug 6, 2024
… added to cart - range from 1 to 10, like on the otel demo astronomy shop website.
…it should be in the center?), split up QuantityChooser into a few composables.
magda-woj
force-pushed
the
product-quantity-selector
branch
from
57fa6f4
to
9e7129c
Compare
|
@breedx-splk web client version also allows to choose from 1 to 10, that's why i did it like that here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… added to cart - range from 1 to 10, like on the otel demo astronomy shop website.