Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker compose servers #426

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Docker compose servers #426

merged 5 commits into from
Jun 17, 2024

Conversation

breedx-splk
Copy link
Contributor

Resolves #345. This will rebase after #424.

It does a few more things with the demo app:

  • Rename from OtelSampleApplication to OtelDemoApplication for consistency with project name (and otel demo)
  • Wire up logs exporter
  • Generate an event in addition to span for logo click on main page
  • Add docker compose and collector configs
  • Updates the README with instructions on how to start up the service(s).

@breedx-splk breedx-splk requested a review from a team June 10, 2024 21:13
@breedx-splk breedx-splk marked this pull request as draft June 11, 2024 15:10
@breedx-splk breedx-splk marked this pull request as ready for review June 11, 2024 22:21
bidetofevil
bidetofevil approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breedx-splk breedx-splk merged commit 3473730 into open-telemetry:main Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidetofevil bidetofevil bidetofevil approved these changes

@marandaneto marandaneto marandaneto approved these changes

@LikeTheSalad LikeTheSalad LikeTheSalad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[demo] Add docker-compose for collector and jaeger
4 participants
@breedx-splk @bidetofevil @marandaneto @LikeTheSalad