-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency versions. #304
Update dependency versions. #304
Conversation
gradle/libs.versions.toml
Outdated
@@ -1,6 +1,7 @@ | |||
[versions] | |||
opentelemetry = "1.37.0" | |||
opentelemetry-alpha = "2.2.0-alpha" | |||
opentelemetry-inst = "2.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's clearer with inst
in the name, to know when you have the instrumentation version (vs. core version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of replacing alpha
with something more meaningful. I would prefer to avoid abbreviations though, I know opentelemetry-instrumentation
could be a lot, though the first time I saw inst
, for some reason "instrumentation" wasn't the first word that came to my mind 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fine, I'll spell out inst
-> instrumentation
...but I'm not going to change semconv. :)
…' into update_gradle_wrapper_validation
The instrumentation bom is not alpha, so this updates that while updating us to the latest. It also updates the gradle version wrapper to the latest name.