Adding Kotlin compile support #189
Conversation
| kotlin { | ||
| compilerOptions { | ||
| jvmTarget.set(JvmTarget.fromTarget(javaVersion.toString())) | ||
| languageVersion.set(minKotlinVersion) |
There was a problem hiding this comment.
| languageVersion.set(minKotlinVersion) | |
| languageVersion.set(minKotlinVersion) | |
| apiVersion.set(minKotlinVersion) |
There was a problem hiding this comment.
Probably has to change in the other places as well
There was a problem hiding this comment.
Cool, I'll make the changes 👍 tbh the docs for that option weren't too clear for me so I wasn't sure if we needed it. Though I guess is better to have it to avoid unexpected issues. We should probably add it in the core repo too, as it's only got languageVersion set.
| sourceCompatibility(javaVersion) | ||
| targetCompatibility(javaVersion) | ||
| isCoreLibraryDesugaringEnabled = true | ||
| } | ||
| } | ||
| kotlin { |
There was a problem hiding this comment.
Usually this configuration goes in the android.kotlinOptions block:
android {
kotlinOptions {
// jvmTarget
// languageVersion
// apiVersion
}
}There was a problem hiding this comment.
It seems like the android.kotlinOptions is just a wrapper of the other config, though yeah it's usually the way Android suggests to set Kotlin stuff so I've made the changes 👍
# Conflicts: # gradle/libs.versions.toml
Related to this discussion.