-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Okhttp callback support #110
Okhttp callback support #110
Conversation
@@ -1,5 +1,7 @@ | |||
# Android Instrumentation for OkHttp version 3.0 and higher | |||
|
|||
# 🚧Work in progress 🚧 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this line because I think we need to warn people not to use this tool until this issue is solved.
...droidTest/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/InstrumentationTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will be interesting to see how we can eliminate the infinite tracing of ourselves. The context key is an interesting approach....
Adds support for instrumenting and properly propagating the Context when making calls using OkHttp callbacks (by calling Call.enqueue)