Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HeaderFunc to allow modifying headers before every request #298

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

BinaryFissionGames
Copy link
Contributor

Adds a new HeaderFunc to the StartSettings that allows for dynamically editing the headers before each HTTP request made by the OpAMP library.

Closes #297

@BinaryFissionGames BinaryFissionGames requested a review from a team September 6, 2024 15:39
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.79%. Comparing base (7cdd395) to head (c35a53d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   77.61%   77.79%   +0.17%     
==========================================
  Files          25       25              
  Lines        1729     1743      +14     
==========================================
+ Hits         1342     1356      +14     
  Misses        283      283              
  Partials      104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andykellr andykellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andykellr
Copy link
Contributor

@tigrannajaryan Please have a look and merge if you approve.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small comment.

client/types/startsettings.go Show resolved Hide resolved
@tigrannajaryan tigrannajaryan merged commit b33ab76 into open-telemetry:main Sep 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dynamically generating headers for each client request
3 participants