Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support client heartbeat #296

Merged
merged 9 commits into from
Aug 30, 2024
Merged

Conversation

haoqixu
Copy link
Member

@haoqixu haoqixu commented Aug 23, 2024

Implement spec change open-telemetry/opamp-spec#190

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (536037b) to head (c451416).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/certs.go 0.00% 3 Missing ⚠️
client/internal/receivedprocessor.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   77.24%   77.27%   +0.02%     
==========================================
  Files          25       25              
  Lines        1692     1729      +37     
==========================================
+ Hits         1307     1336      +29     
- Misses        282      286       +4     
- Partials      103      107       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoqixu haoqixu force-pushed the f-heartbeat branch 2 times, most recently from 0ac7588 to 52d2bef Compare August 23, 2024 16:05
@haoqixu haoqixu marked this pull request as ready for review August 23, 2024 16:56
@haoqixu haoqixu requested a review from a team August 23, 2024 16:56
@haoqixu
Copy link
Member Author

haoqixu commented Aug 27, 2024

@jaronoff97, considering you are the author of open-telemetry/opamp-spec#190, you might find this PR of interest and perhaps may want to review it.

Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one thought, otherwise this looks great.

client/internal/wssender.go Outdated Show resolved Hide resolved
client/internal/httpsender.go Outdated Show resolved Hide resolved
client/internal/receivedprocessor.go Outdated Show resolved Hide resolved
client/internal/wssender.go Outdated Show resolved Hide resolved
client/internal/wssender.go Show resolved Hide resolved
client/internal/wssender.go Show resolved Hide resolved
@tigrannajaryan tigrannajaryan merged commit 7cdd395 into open-telemetry:main Aug 30, 2024
7 checks passed
@tigrannajaryan
Copy link
Member

Thanks @haoqixu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants