-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support client heartbeat #296
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 77.24% 77.27% +0.02%
==========================================
Files 25 25
Lines 1692 1729 +37
==========================================
+ Hits 1307 1336 +29
- Misses 282 286 +4
- Partials 103 107 +4 ☔ View full report in Codecov by Sentry. |
0ac7588
to
52d2bef
Compare
@jaronoff97, considering you are the author of open-telemetry/opamp-spec#190, you might find this PR of interest and perhaps may want to review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one thought, otherwise this looks great.
Thanks @haoqixu ! |
Implement spec change open-telemetry/opamp-spec#190